Add missing id attribute to the Reader.php#895
Add missing id attribute to the Reader.php#895FY0u11 wants to merge 3 commits intomagento:developfrom
Conversation
engcom-Hotel
left a comment
There was a problem hiding this comment.
Hello @FY0u11,
Thanks for the contribution!
Please sign the CLA so that we can move further with this PR.
Thanks
|
@magento run all tests |
engcom-Hotel
left a comment
There was a problem hiding this comment.
Hello @FY0u11,
Thanks for the collaboration!
The changes seems good to us, but please fix the failed static test and also mention the steps to reproduce the issue.
Thanks
|
Hello @FY0u11, Gentle reminder for this #895 (review). Thanks |
Corrected copyright year
|
@magento run Static Tests |
|
@magento run all tests |
|
@magento run Functional Tests B2B, Functional Tests CE, Integration Tests, WebAPI Tests |
|
Hello @FY0u11, We have resolved the static test failures of this PR. We need some manual testing scenarios to move further with this PR. Please let us know about the same. Meanwhile moving this PR Thanks |
|
Hello @FY0u11, Please provide us some manual testing scenario/Steps to reproduce the issue. Thanks |
|
Hello @FY0u11, Gentle reminder for this PR. Thanks |
Add a missing ID attribute to the pagebuilder's config content type reader.
Description (*)
You can see that the commit only adds a single line of code. The reason we need this line is to allow developers to extend the additional_data/item[name="uploaderConfig"] key in the view/adminhtml/pagebuilder/content_type/*.xml files. I'm not sure whether the absence of this key was intentional or not, but without this fix, attempting to extend these XML files in a custom module will result in an exception. Personally, I tried to extend image.xml, banner.xml, and slide.xml to add webp and avif to the allowedExtensions.
Story
Bug
Task
Fixed Issues (if relevant)
Builds
Related Pull Requests
Manual testing scenarios (*)
Questions or comments
Checklist