Fixed Banner element overlay issue on mobile when min-height is customized#899
Fixed Banner element overlay issue on mobile when min-height is customized#899ChavdaNayan wants to merge 3 commits intomagento:developfrom
Conversation
|
@magento create issue |
|
@magento run all tests |
engcom-Hotel
left a comment
There was a problem hiding this comment.
Hello @ChavdaNayan,
Thanks for the contribution!
The changes looks good to us, but please fix the failed static test failures. Other failures seems flaky to me.
Thanks
|
@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Unit Tests |
|
@magento run all tests |
|
Hello @engcom-Hotel |
engcom-Hotel
left a comment
There was a problem hiding this comment.
Hello @ChavdaNayan,
Thanks for making the changes!
The failed tests seems flaky to me, but please fix the copyright year below.
Thanks
| /** | ||
| * Copyright © Magento, Inc. All rights reserved. | ||
| * See COPYING.txt for license details. | ||
| * Copyright 2025 Adobe |
There was a problem hiding this comment.
Copyright year should be the year when the file was created:
| * Copyright 2025 Adobe | |
| * Copyright 2018 Adobe |
There was a problem hiding this comment.
Hello @engcom-Hotel
Changed the copyright year to reflect the file's creation year.
|
@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests |
|
@magento run all tests |
|
Hi @ChavdaNayan, Thanks for your Contribution!! ❌ QA FailedPreconditions:
Before: ✖️
After: ✔️
After taking PR changes also the button still not showing up in Mobile view.Could you please let us know if we are still missing anything. Thanks. |
|
Thanks @engcom-Bravo for the QA! As the QA is failed for this PR, hence moving it to Thanks |
|
Hi @ChavdaNayan, Thanks for your Contribution!!. Did you get a chance to look into this #899 (comment) and please let us know if we are missing anything and provide latest update if possible. Thanks. |
1 similar comment
|
Hi @ChavdaNayan, Thanks for your Contribution!!. Did you get a chance to look into this #899 (comment) and please let us know if we are missing anything and provide latest update if possible. Thanks. |



Preconditions (*)
Tested in this versions:
Magento 2.4.8
Description (*)
When we set a custom minimum height for the banner, the content overlay doesn’t show up on the mobile frontend.
Steps to reproduce (*)
Screenshot-1
Expected result (*)
When setting a custom minimum height value for the Banner element in Page Builder’s mobile view, the content overlay (text/button layer) should be visible (See Screenshot 2).
Screenshot-2
Actual result (*)
When setting a custom minimum height value for the Banner element in Page Builder’s mobile view, the content overlay (text/button layer) is not clearly visible (See Screenshot 3).
Screenshot-3
Additional information (*)
In the banner element on mobile viewports, when we change the custom minimum height value, the banner overlay background color becomes transparent (See Screenshot 4).
Screenshot-4
Resolved issues: