Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve user experience with roles tree #36511

Open
wants to merge 8 commits into
base: 2.4-develop
Choose a base branch
from
Open

Improve user experience with roles tree #36511

wants to merge 8 commits into from

Conversation

fredden
Copy link
Member

@fredden fredden commented Nov 22, 2022 •
edited by m2-assistant bot
Loading

Description

When working with the roles tree, it's easy to get lost with the long list of possible options. This pull request adds buttons to collapse all, expand all, and expand branches with selected items. This functionality is similar to that provided in the category tree (Catalog -> Inventory -> Categories).

Manual testing scenarios

  1. Navigate to a list of roles in the admin
    • System -> Extensions -> Integrations -> [Edit, or Add New Integration] -> Basic Settings -> API -> Available APIs -> Resources
    • System -> Permissions -> User Roles -> [Edit, or Add New Role] -> Role Information -> Role Resources -> Roles Resources -> Resources
  2. Select a few items from the list. For best effect, choose one or two deeply nested items from different branches.
  3. Take a concise screen-shot showing which top-level areas the role / integration will have access to. (Note the 'collapse all' button.)
  4. Select a new item from a previously unused branch. (Note the 'expand all' button.)
  5. Take a concise screen-shot showing which exact permissions the role / integration will have access to. (Note the 'collapse all' and 'expand selected' buttons.)

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Improve user experience with roles tree #39654: Improve user experience with roles tree

@m2-github-services m2-github-services added Partner: Fisheye partners-contribution Pull Request is created by Magento Partner labels Nov 22, 2022
@m2-assistant
Copy link

m2-assistant bot commented Nov 22, 2022

Hi @fredden. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie engcom-Charlie added the Priority: P3 May be fixed according to the position in the backlog. label Dec 6, 2022
@Priyakshic Priyakshic added the Project: Community Picked PRs upvoted by the community label Feb 12, 2025
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel engcom-Hotel self-requested a review February 21, 2025 09:32
@engcom-Bravo
Copy link
Contributor

@magento run all tests

@engcom-Bravo
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Feb 24, 2025
Open
5 tasks
@engcom-Bravo
Copy link
Contributor

Hi @fredden,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Steps to reproduce

  • Navigate to a list of roles in the admin
  • System -> Extensions -> Integrations -> [Edit, or Add New Integration] -> Basic Settings -> API -> Available APIs -> Resources
  • System -> Permissions -> User Roles -> [Edit, or Add New Role] -> Role Information -> Role Resources -> Roles Resources -> Resources
  • Select a few items from the list. For best effect, choose one or two deeply nested items from different branches.
  • Take a concise screen-shot showing which top-level areas the role / integration will have access to. (Note the 'collapse all' button.)
  • Select a new item from a previously unused branch. (Note the 'expand all' button.)
  • Take a concise screen-shot showing which exact permissions the role / integration will have access to. (Note the 'collapse all' and 'expand selected' buttons.)

Before: ✖️ 

Administrators-Roles-Permissions-System-Magento-Admin-02-24-2025_01_02_PM

Edit-Test-Integration-Extensions-System-Magento-Admin-02-24-2025_12_52_PM

After: ✔️

Edit-Test-Integration-Extensions-System-Magento-Admin-02-24-2025_12_59_PM

Screenshot 2025-02-24 at 1 01 41 pm

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

@engcom-Charlie engcom-Charlie self-assigned this Feb 27, 2025
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run Database Compare, Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Static Tests, Unit Tests, WebAPI Tests

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B, Static Tests

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B

@engcom-Charlie
Copy link
Contributor

The Functional B2B failure is constant in both the recent builds but its a known issue. The test failure is neither related to PR nor part of this PR. Hence moving this PR to Merge in Progress

Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36511/08910a664432d3ec9b9a859893a1ea12/Functional/allure-report-b2b/index.html#categories

image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36511/ee5142a71e1751eb56c5920da5f1d123/Functional/allure-report-b2b/index.html

image

Known Issues:
ACQE-7641: AdminValidateMixedNestedCategoryInWidgetTest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel approved these changes

Assignees

@engcom-Charlie engcom-Charlie

Labels
Partner: Fisheye partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: ready for testing Project: Community Picked PRs upvoted by the community
Projects
Community Dashboard
Status: Merge in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Improve user experience with roles tree
6 participants
@fredden @engcom-Hotel @engcom-Bravo @engcom-Charlie @m2-github-services @Priyakshic