Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sticky header for navigation in mobile, desktop #26135 #26447

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from
Open

Sticky header for navigation in mobile, desktop #26135 #26447

wants to merge 1 commit into from

Conversation

vimal-ranosys
Copy link
Contributor

@vimal-ranosys vimal-ranosys commented Jan 18, 2020 •
edited by sdzhepa
Loading

Description (*)

Fixed Issues (if relevant)

  1. fixes Sticky header for navigation in mobile, desktop #26135:Sticky header for navigation in mobile, desktop

Manual testing scenarios (*)

  1. Verified in desktop and mobile browsers

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 18, 2020

Hi @vimal-ranosys. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@mrtuvn mrtuvn mentioned this pull request Apr 6, 2020
Closed
4 tasks
mrtuvn
mrtuvn requested changes Apr 6, 2020
View reviewed changes
app/design/frontend/Magento/blank/web/css/source/_sticky-nav.less
@@ -0,0 +1,16 @@
@media(min-width:768px){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please use media-width query standards of magento instead native

@ghost ghost added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. and removed Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels May 21, 2020
@mrtuvn mrtuvn mentioned this pull request Jul 9, 2020
Closed
4 tasks
@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrtuvn mrtuvn mrtuvn requested changes

Assignees
No one assigned
Labels
Area: Design/Frontend Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: pending review Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sticky header for navigation in mobile, desktop
4 participants
@vimal-ranosys @mrtuvn @magento-engcom-team @periwalbhanu