Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar is not align proper in mywishlist page in mobile view #30432 fixed #30433

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

cedarvinda
Copy link
Member

@cedarvinda cedarvinda commented Oct 10, 2020

Fixes #30432

Toolbar is not align proper in mywishlist page in mobile view #30432 fixed
Description
Toolbar is not align proper in MyWishlist page in mobile view
Preconditions (*)

Magento2.4
php7.4

###Steps to reproduce (*)

open magento base url.
tab sign in on top right of screen.
enter email id and password to sign in your account.
go to my wishlist page and open mobile view.
check toolbar-amount and limiter design in mobile view (and compare with my orders page in mobiel view)

Expected result (*)
wishlist_solution_1

Actual result (*)
wishlist_issue_1

@m2-assistant
Copy link

m2-assistant bot commented Oct 10, 2020

Hi @cedarvinda. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sivaschenko
Copy link
Member

#dmcdindia2020

@cedarvinda cedarvinda changed the title Toolbar is not align proper in mywishlist page in mobile view #30432 … Fixed now Toolbar is not align proper in mywishlist page in mobile view #30432 fixed Oct 10, 2020
@sivaschenko sivaschenko added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Oct 10, 2020
@mrtuvn
Copy link
Contributor

mrtuvn commented Oct 10, 2020

here is my mobile screen. Latest code base

wishlist-mobile
luma wishlist mobile iphoneX screen

&.wishlist-toolbar {
.limiter {
float: none;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO you can use flexbox for arrange layout easier than this

Copy link
Contributor

@mrtuvn mrtuvn Oct 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example
less.toolbar { &.wishlist-toolbar { .pager { .lib-vendor-prefix-display(); align-items: center; flex-wrap: wrap; justify-content: space-between; } } }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Event: dmcdindia2020 Partner: Cedcommerce partners-contribution Pull Request is created by Magento Partner Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: pending review Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toolbar is not align proper in mywishlist page in mobile view
4 participants