Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bulk ACL Admin Ui #30806

Open
wants to merge 9 commits into
base: 2.4-develop
Choose a base branch
from
Open

Bulk ACL Admin Ui #30806

wants to merge 9 commits into from

Conversation

engcom-Charlie
Copy link
Contributor

@engcom-Charlie engcom-Charlie commented Nov 5, 2020 •
edited
Loading

Description (*)

Recreated from #27580

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes [Issue] Bulk ACL management for AsynchronousOperations Admin UI #29757

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 5, 2020

Hi @engcom-Charlie. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@engcom-Charlie
Copy link
Contributor Author

@magento run all tests

@engcom-Charlie
Copy link
Contributor Author

@magento run all tests

@engcom-Charlie engcom-Charlie changed the title [WIP] Bulk ACL Admin Ui Bulk ACL Admin Ui Nov 9, 2020
@sidolov sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Nov 9, 2020
@engcom-Charlie engcom-Charlie mentioned this pull request Dec 2, 2020
Closed
5 tasks
@nuzil
Copy link
Contributor

nuzil commented Dec 3, 2020

I definitely sure I know code of this Pull Request :-)
Thanks a lot for taking it over, cause unfortunately I had no time to finish

@nuzil nuzil self-requested a review December 3, 2020 16:04
@nuzil nuzil self-assigned this Dec 3, 2020
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor Author

@magento run Semantic Version Checker, Functional Tests B2B , Static Tests , WebAPI Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor Author

@magento run Semantic Version Checker, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor Author

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor Author

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie engcom-Charlie self-assigned this May 18, 2022
@engcom-Charlie
Copy link
Contributor Author

Raised SVC approval JIRA ticket for this PR.

Waiting for the approval now.

@engcom-Charlie
Copy link
Contributor Author

engcom-Charlie commented Oct 21, 2022 •
edited
Loading

Raised new SVC approval JIRA ticket on adobe portal for this PR.

Waiting for the approval now.

@engcom-Charlie
Copy link
Contributor Author

@magento run Semantic Version Checker

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor Author

@magento run Semantic Version Checker

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor Author

engcom-Charlie commented Mar 19, 2024 •
edited
Loading

As the branch is showing conflicts, moving this PR to Changes Requested again.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Foxtrot engcom-Foxtrot engcom-Foxtrot left review comments

@engcom-Alfa engcom-Alfa engcom-Alfa requested changes

@nuzil nuzil nuzil approved these changes

Assignees

@nuzil nuzil

@dmitriyprime dmitriyprime

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

@engcom-Foxtrot engcom-Foxtrot

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: advanced Award: category of expertise Award: complex Award: test coverage Component: AsynchronousOperations Component: Bulk Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: needs update Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Pull Requests Dashboard
Status: Changes Requested
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Bulk ACL management for AsynchronousOperations Admin UI
7 participants
@engcom-Charlie @nuzil @engcom-Foxtrot @magento-engcom-team @dmitriyprime @sidolov @engcom-Alfa