Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated readme file for tax, taxGraphQl, taxImportExport, theme, themeGraphQl, Tinymce3, and translation #31491

Open
wants to merge 22 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

chiranjeevi-cj
Copy link
Contributor

@chiranjeevi-cj chiranjeevi-cj commented Dec 30, 2020

Description (*)

Update README.md file:

  • Magento_Tax
  • Magento_TaxGraphQl
  • Magento_TaxImportExport
  • Magento_Theme
  • Magento_ThemeGraphQl
  • Magento_Tinymce3
  • Magento_Translation

Fixed Issues (if relevant)

  1. Fixes magento/devdocs README content for modules - work in M2 Code devdocs#4451: README content for modules - work in M2 Code

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 30, 2020

Hi @chiranjeevi-cj. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@chiranjeevi-cj
Copy link
Contributor Author

@magento run all tests

@sidolov sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jan 4, 2021
# Magento_Tax module

The **Magento_Tax** module provides the calculations needed to compute the consumption tax on goods and services.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I have said in other reviews, remove bolding and all instances of "please".

Copy link
Contributor

@sidolov sidolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chiranjeevi-cj please, resolve merge conflicts

@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented Jan 25, 2022

Hi @chiranjeevi-cj,

Thank you for your contribution!

I will look into the branch conflicts and changes requested.

Thank you!

@engcom-Charlie
Copy link
Contributor

I have resolved the merged conflicts.

It seems that the requested changes have been taken care already. @dobooth can you please review the changes.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Tax Component: TaxGraphQl Component: TaxImportExport Component: Theme Component: ThemeGraphQl Component: Tinymce Component: Translation Partner: EY partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants