-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent behaviour for disallowed path's errors #31583
base: 2.4-develop
Are you sure you want to change the base?
Conversation
Hi @kassner. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kassner, thanks for contributing! Can you have a look at my comments below?
Also, as part of our Definition of Done, we must cover changes with automated tests, depending on the how we proceed with this PR we may use Integration tests to cover it, what do you think?
Thanks again!
throw new LogicException('The path is not allowed: ' . $this->relativeFileName); | ||
require_once 'errors/404.php'; | ||
exit; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we shouldn't remove the exception from here, instead, we should handle it properly where we believe that the 404 should be displayed. Other clients that use this function may react differently than show 404 and exit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is fully encapsulated in the \Magento\Framework\App\Bootstrap class, so there is no way to handle this exception from pub/get.php.
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
Description
If the
var/resource_config.json
file exists, requests to invalid paths are handled by this piece of code, but when the file doesn't, it is handled by another class, which has a different behaviour.Fixed Issues
Manual testing scenarios
Contribution checklist