Make method signature consistent with interface

[kassner]

Description

The interface uses $entityTypeCode. This makes psalm fail without a solution if you are overwriting the method:

With $entityType:

ERROR: ParamNameMismatch - app/code/My/Module/Model/EavAttributeManagement.php:39:35 - Argument 1 of Yubico\Catalog\Model\EavAttributeManagement::getAttributes has wrong name $entityType, expecting $entityTypeCode as defined by Magento\Eav\Api\AttributeManagementInterface::getAttributes (see https://psalm.dev/230)
    public function getAttributes($entityType, $attributeSetId)

With $entityTypeCode:

ERROR: ParamNameMismatch - app/code/My/Module/Model/EavAttributeManagement.php:39:35 - Argument 1 of Yubico\Catalog\Model\EavAttributeManagement::getAttributes has wrong name $entityTypeCode, expecting $entityType as defined by Magento\Eav\Model\AttributeManagement::getAttributes (see https://psalm.dev/230)
    public function getAttributes($entityTypeCode, $attributeSetId)

Manual testing scenarios

1. Create a class that overwrites \Magento\Eav\Model\AttributeManagement::getAttributes();
2. Run psalm on your file;

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Make method signature consistent with interface #38501: Make method signature consistent with interface

[m2-assistant]

Hi @kassner. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[ihor-sviziev]

@magento run all tests

[ihor-sviziev]

@magento run Functional Tests B2B, Functional Tests EE, WebAPI Tests

[ihor-sviziev]

@magento run Functional Tests B2B, Functional Tests EE

[ihor-sviziev]

✔ Approved.

Failing tests looks not related to changes form this PR.

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8732 has been created to process this Pull Request

[ihor-sviziev]

@magento run Functional Tests B2B, Functional Tests EE

[ihor-sviziev]

@magento run Functional Tests B2B, Functional Tests EE

[Den4ik]

@magento run Functional Tests B2B, Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ihor-sviziev]

@magento run Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Den4ik]

I like when Magento have pure code 👍

[magento-engcom-team]

Hi @Den4ik, thank you for the review.
ENGCOM-8732 has been created to process this Pull Request

[engcom-Delta]

@magento create issue

[engcom-Dash]

QA is not required for this change since it only updates the variable name.

Builds are failing so moving it to extended testing.

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run Unit Tests, Integration Tests, Functional Tests B2B

[engcom-Dash]

The Functional B2B seems to be flaky, and there is a known issue, hence moving it to Merge in Progress.

Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31955/3db7144166f8b79c3b9c7f8ea8d60739/Functional/allure-report-b2b/index.html#categories/bdbf199525818fae7a8651db9eafe741

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31955/bb282470e190985f0009c1758c5fc747/Functional/allure-report-b2b/index.html#categories/16b25a50b4a8b68f5548cdba82ebd5f8/3d1f7df58e28442a/