Fixed return type declaration for Backend menu command factory

[Den4ik]

Description (*)

Fixed return type declaration

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

1. Check code of changed file

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @Den4ik. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[Den4ik]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Den4ik]

I believe that semantic version check could be ignored in this case, because return type used in doc block is not correct

[BarnyShergold]

@magento run Functional Tests B2B,Semantic Version Checker

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[BarnyShergold]

Looks good - agree about the Version Checker.

[magento-engcom-team]

Hi @BarnyShergold, thank you for the review.
ENGCOM-9226 has been created to process this Pull Request

[BarnyShergold]

@magento run Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[BarnyShergold]

@magento run Functional Tests B2B,Semantic Version Checker

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[BarnyShergold]

@magento run Functional Tests B2B,Semantic Version Checker

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[BarnyShergold]

@magento run Semantic Version Checker

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Alfa]

Hi @Den4ik and @BarnyShergold
Thanks for your collaboration and contribution!

By looking into the file changes, noticed that return type of the function public function create($commandName, array $data = []) has been changed to @return AbstractCommand.

1. AbstractCommand has no class path declared completely.
2. Keeping the same @return \Magento\Config\Model\Config return type, what is the issue will face? If we have any issue with this return type, Could you please give us the complete steps to reproduce it? It will help to process the ticket forward from testing phase.

Thanks in advance!

[engcom-Alfa]

@magento run Semantic Version Checker

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Den4ik]

@engcom-Alfa Semantic Version Check will be failed, but I believe that it can be ignored in because return type used in doc block is not correct

[engcom-Alfa]

@engcom-Alfa Semantic Version Check will be failed, but I believe that it can be ignored in because return type used in doc block is not correct

Sure, I will. Can you please help me with my above-comment, so that I can work on this ticket. Thanks in advance.

[engcom-Alfa]

✔️ QA Passed

As discussed with a couple of developers about the file changed in this PR and clarified that the changes are fulfilling the coding standards that were missed here.
There is no functional impact as such using this PR, hence approving it for further process.

[Den4ik]

@sidolov could you please assist due to accept at Jan 21

[ishakhsuvarov]

Moving this to To Approve to get SVC approval.

@engcom-Charlie Please figure out what needs to be done to create and process an approval ticket.

[engcom-Echo]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Echo]

@magento run Integration Tests, Functional Tests B2B, Functional Tests CE, Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Echo]

For SVC approval we have raised internal JIRA. Hence we are moving it to pending approval.