Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up ruleset mixins at less file luma theme #35359

Draft
wants to merge 11 commits into
base: 2.4-develop
Choose a base branch
from
Draft

Clean up ruleset mixins at less file luma theme #35359

wants to merge 11 commits into from

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Apr 24, 2022 •
edited
Loading

Description (*)

Update for luma theme only. Previously fixed in blank theme at ticket #35101
Clean up ruleset mixins for luma theme (less)
=> Better approach
Selectors in referenced files expect that they have to be extended in OTHER NOT REFERENCED files. Don't use extend in the same referenced file.
Grunt doesn't compile extend selectors even without wrappers, such as: media-common or media mixins.
Use mixin instead of extend in the referenced file.

Current: &:extend(.abs-account-title all);
Better: @abs-account-title(); => mixins

Fix calc work at datepicker input

Related Pull Requests

#35101

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. Compile styles via default deploying (setup:static-content:deploy) and via Grunt.
  2. Config theme to luma -> Look at block titles of My Account (they should look the same after all build processes).
  3. Enable show DOB of customer field in backend4.
  4. Go to frontend to visually changes5.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 24, 2022

Hi @mrtuvn. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@mrtuvn mrtuvn force-pushed the less-luma-cleanup-extend-less branch from c2a7476 to 60def0f Compare April 24, 2022 10:10
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Apr 24, 2022

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@sidolov sidolov added the Priority: P3 May be fixed according to the position in the backlog. label Apr 28, 2022
@mrtuvn mrtuvn force-pushed the less-luma-cleanup-extend-less branch from 60def0f to 5a526f8 Compare April 28, 2022 23:55
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Apr 28, 2022

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jun 25, 2022

@magento run Static Tests, Integration Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Oct 13, 2022

@magento run Static Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jan 26, 2023

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jan 27, 2023

@magento run Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jan 28, 2023

@magento run Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Feb 2, 2023

@magento run Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Feb 25, 2023

Same pull request 35101 but apply/fix for luma theme. Expect everything should work same as before
UI -> customer account
UI -> customer login/register form (with additional fields, date of birth , telephone v.v.))
Can you recheck for me @engcom-Echo
Thanks

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Mar 2, 2023

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Mar 3, 2023

@magento run Functional Tests CE, Functional Tests EE, WebAPI Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Mar 3, 2023

looks like fail alarm at Functional Tests CE

@mrtuvn mrtuvn added Area: Perf/Frontend All tickets related with improving frontend performance. and removed Area: Perf/Frontend All tickets related with improving frontend performance. labels Mar 8, 2023
@mrtuvn mrtuvn marked this pull request as draft March 18, 2023 15:00
fredden
fredden reviewed Jul 5, 2023
View reviewed changes
app/design/frontend/Magento/luma/web/css/source/_extends.less Outdated
Comment on lines 10 to 12
/**
* @codingStandardsIgnoreStart
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular rule in the coding standard that needs to be adjusted, or something here that should be corrected to conform?

Suggested change
/**
* @codingStandardsIgnoreStart
*/

Copy link
Contributor Author

@mrtuvn mrtuvn Jul 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it's shoud be remove for correct syntax and check validate

@mrtuvn mrtuvn marked this pull request as ready for review July 6, 2023 02:46
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jul 6, 2023

@magento run Static Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@mrtuvn mrtuvn marked this pull request as draft July 13, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredden fredden fredden left review comments

Assignees

@fredden fredden

@engcom-Echo engcom-Echo

Labels
Area: Design/Frontend Priority: P3 May be fixed according to the position in the backlog. Progress: review Type: Code Cleanup
Projects
Pull Requests Dashboard
Status: Review in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mrtuvn @fredden @sidolov @engcom-Echo @tuna2smc