Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply hover color for static grids in admin #35384

Open
wants to merge 13 commits into
base: 2.4-develop
Choose a base branch
from
Open

Apply hover color for static grids in admin #35384

wants to merge 13 commits into from

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented Apr 27, 2022 •
edited by engcom-November
Loading

Description (*)

This PR add hover background to static grids in admin

Actual result
Screenshot 2022-04-27 at 17 07 09

Related Pull Requests

https://github.com/magento-gl/magento2ee/pull/421

Fixed Issues (if relevant)

  1. Fixes Hover colour not applied on static grids in admin #35358

@m2-assistant
Copy link

m2-assistant bot commented Apr 27, 2022

Hi @Usik2203. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-github-services m2-github-services added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Apr 27, 2022
@m2-community-project m2-community-project bot added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Apr 27, 2022
@ihor-sviziev ihor-sviziev added Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Risk: low Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Apr 28, 2022
@ihor-sviziev ihor-sviziev self-assigned this Apr 28, 2022
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ihor-sviziev
Copy link
Contributor

@sidolov, can we increase priority to P2 as this change has low risk and improves UX working with grids in admin?

@ihor-sviziev ihor-sviziev added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. and removed Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. labels Jan 8, 2024
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Unit Tests, WebAPI Tests

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-November
Copy link
Contributor

@magento run all tests

@engcom-November engcom-November self-assigned this Sep 6, 2024
@engcom-November
Copy link
Contributor

@magento run all tests

@engcom-November
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests

@engcom-November
Copy link
Contributor

There are 7 repeating broken tests which are flaky in Functional Tests B2B, CE and EE.

Functional Tests B2B:
Run 1:
image

Run 2:
image

Functional Tests CE:
Run 1:
image

Run 2:
image

Functional Tests EE:
Run 1:
image

Run 2:
image

As these are not related to PR changes moving this to Merge in progress

@m2-community-project m2-community-project bot added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Oct 4, 2024
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

The build URL has not been attached in comment about flaky tests. Now, after rerunning the build, as the build is failing, moving this PR back to Extended Testing.

image

@engcom-Charlie
Copy link
Contributor

@magento run Static Tests

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

@engcom-Charlie
Copy link
Contributor

The unit test failures are known issues and not related to PR or PR changes.

Known issue:
ACQP-3896

@engcom-Charlie
Copy link
Contributor

I have fixed 2 static test failures.

The remaining test failure in recent build result is not part of this PR.

@engcom-Charlie
Copy link
Contributor

Moving this PR to Merge in Progress as one of the Functional B2B and EE failure is not consistent in recent 2 builds with same code base. The remaining one failure is known issues and having a open JIRA for the same.

Functional B2B
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/35384/e0938582def636498df2044a582f9937/Functional/allure-report-b2b/index.html#categories

image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/35384/dae21faf3a3b0460d990ec80255bca08/Functional/allure-report-b2b/index.html

image

Functional EE:
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/35384/6b4d2c6905b726ef9163865c4670dfed/Functional/allure-report-ee/index.html#categories

image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/35384/58495eacd82d754274227959d3a99fbd/Functional/allure-report-ee/index.html#categories

image

The Functional CE is consistent in 2 builds, its a known issue. Not related to PR changes.

Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/35384/6f08973e105734edd72159561fb1a086/Functional/allure-report-ce/index.html#categories

image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/35384/8c4cce2b93ac0729bc4f7b2553f4cc73/Functional/allure-report-ce/index.html#categories

image

Known Issue:
ACQE-6591: AdminCreateUserRoleWithLimitedPermissionTest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Charlie engcom-Charlie

@engcom-Echo engcom-Echo

@engcom-November engcom-November

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept Risk: low Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
Status: Merge in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hover colour not applied on static grids in admin
7 participants
@Usik2203 @ihor-sviziev @engcom-Delta @engcom-Echo @engcom-Charlie @engcom-November @m2-github-services