Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration test issue with interceptor #37187

Open
wants to merge 7 commits into
base: 2.4-develop
Choose a base branch
from
Open

Fix integration test issue with interceptor #37187

wants to merge 7 commits into from

Conversation

AntonEvers
Copy link
Contributor

@AntonEvers AntonEvers commented Mar 10, 2023 •
edited by m2-assistant bot
Loading

I have seen the following error:

Property Magento\TestFramework\App\Config\Interceptor::$data does not exist

This is because \Magento\TestFramework\Store\StoreManager::reinitStores does not take into account that \Magento\TestFramework\App\Config as returned from the ObjectManager might just as well be a \Magento\TestFramework\App\Config\Interceptor, in case a plugin on that class exists for example.

To be able to still get the data that is needed for the test, there is the need to test for the implementation of \Magento\Framework\Interception\InterceptorInterface and get the $data property from the parent.

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Fix integration test issue with interceptor #37383: Fix integration test issue with interceptor

Resolved issues:

  1. resolves [Issue] Fix integration test issue with interceptor #39324: Fix integration test issue with interceptor

@AntonEvers
Fix integration test issue with interceptor
daf4a5f 
I have seen the following error:
```
Property Magento\TestFramework\App\Config\Interceptor::$data does not exist
```
This is because `\Magento\TestFramework\Store\StoreManager::reinitStores` does not take into account that \Magento\TestFramework\App\Config as returned from the ObjectManager might just as well be a `\Magento\TestFramework\App\Config\Interceptor`, in case a plugin on that class exists for example.

To be able to still get the data that is needed for the test, there is the need to test for the implementation of \Magento\Framework\Interception\InterceptorInterface and get the $data property from the parent.
@m2-assistant
Copy link

m2-assistant bot commented Mar 10, 2023

Hi @AntonEvers. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@AntonEvers
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 28, 2023
@ihor-sviziev ihor-sviziev self-assigned this Apr 13, 2023
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE, Integration Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev
ihor-sviziev approved these changes Apr 16, 2023
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔ Approved.

Failing tests look not related to changes from this PR.

@engcom-Lima
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Lima
Copy link
Contributor

@magento run Functional Tests B2B, WebAPI Tests

@engcom-Lima
Copy link
Contributor

@magento run Functional Tests EE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Lima
Copy link
Contributor

@magento run WebAPI Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Lima
Copy link
Contributor

@magento Functional Tests EE

@engcom-Lima engcom-Lima removed their assignment Apr 18, 2023
@engcom-Lima engcom-Lima added Progress: testing in progress Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it and removed Progress: ready for testing labels Apr 18, 2023
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Apr 19, 2023
@Hawksama
Copy link

Up. This error is still happening in M2.4.7 when creating new stores in Unit Tests.

@engcom-Dash engcom-Dash self-assigned this Oct 29, 2024
@engcom-Dash
Copy link
Contributor

Hi @AntonEvers,

Thanks for the collaboration & contribution!

✔️ QA Passed
Preconditions:

  • Install fresh Magento 2.4-develop

Steps to reproduce

  • Create a plugin for Magento\Framework\App\Config\ScopeConfigInterface
  • Create an integration test class that creates a new store or run an existing integration test that calls Magento\TestFramework\Store\StoreManager::reinitStores. For example, see: Magento/Catalog/Model/Attribute/Backend/WebsiteSpecific/ValueSynchronizerTest.php

Before: ✖️
image

After: ✔️
image

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Nov 4, 2024
Open
6 tasks
@engcom-Dash
Copy link
Contributor

@magento run Static Tests, Functional Tests B2B

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Integration Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B

@engcom-Dash
Copy link
Contributor

The Functional EE test failures are different in recent 2 successive builds. They neither part of PR nor failing because of the PR changes, hence moving it to Merge in Progress.

Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/37187/8a6df4dc31de846608d1e326aa1ac1f2/Functional/allure-report-ee/index.html#categories/3e783d9810b21b0bfa2c0261030c68a9/90d7c732d52ca5fc/
image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/37187/7457de28dcfa3b331a6f27a67f934504/Functional/allure-report-ee/index.html#categories/dabfadd59f1a7ac0df1ce9f37aec2ad5/f29e692f10aec123/
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Dash engcom-Dash

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for testing Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it Type: Bug Fix
Projects
Pull Requests Dashboard
Status: Merge in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Fix integration test issue with interceptor [Issue] Fix integration test issue with interceptor
6 participants
@AntonEvers @ihor-sviziev @engcom-Lima @Hawksama @engcom-Dash @engcom-Hotel