-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a check for the presence of the parameter for the bin/magento downloadable:domains
commands
#38409
base: 2.4-develop
Are you sure you want to change the base?
Add a check for the presence of the parameter for the bin/magento downloadable:domains
commands
#38409
Conversation
…wnloadable:domains:add`
…wnloadable:domains:remove`
Hi @YevhenZvieriev. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
bin/magento downloadable:domains:add
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues. |
bin/magento downloadable:domains:add
bin/magento downloadable:domains
commands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @YevhenZvieriev
Thank you for your contribution
Could you please fix code to fix the static test failures
Thank you in advance
…er' into fix/downloadable-domains-parameter
…use the DownloadManager class instead of static methods to fix static tests
@magento run all tests |
Hello @andrewbess After fixing the static test issues, the code is now passing every static test. Kindly take a moment to review the revised version of the PR. |
@magento run all tests |
@magento run all tests |
Description
Update to the bin/magento downloadable:domains:add and bin/magento downloadable:domains:remove commands
Upon reviewing the usage of the
bin/magento downloadable:domains:add
andbin/magento downloadable:domains:remove
commands, it was noticed that when these commands are invoked without passing a parameter, nothing happens, and the user receives an unclear outcome.In this Pull Request, a new feature has been added to display an error message if the parameter is missing. Users will now receive a clear notification that they forgot to pass a parameter when invoking these commands.
Changes
bin/magento downloadable:domains:add
andbin/magento downloadable:domains:remove
commands.These changes enhance the user experience and prevent the unintended execution of commands without passing the required parameter.
Before:
After:
Contribution checklist (*)