-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop page id from result #38667
base: 2.4-develop
Are you sure you want to change the base?
Drop page id from result #38667
Conversation
Hi @thomas-kl1. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run Unit Tests |
In continuity to 0ce7599 My requested changes still makes sense because the expected behavior of the service is to return a list of identifiers from the current scope. I'm going to update the PR to align changes. |
@magento run all tests |
Description (*)
Given the unit test: \Magento\Cms\Test\Unit\Model\GetUtilityPageIdentifiersTest::testExecute
Expected result is a list of identifiers.
Currently, if we set the following settings from BO:
The format saved in the config is: |<page_id>
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)