-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Exceptions in Asset Repository Functions #38975
base: 2.4-develop
Are you sure you want to change the base?
Conversation
The `updateDesignParams()` function has the capacity to throw the `UnexpectedValueException` but this is not documented in either of the functions that call it. Additionally, the `createAsset()` function has the potential to throw a `LocalizedException` which is not documented by either of the functions that make use of it.
Hi @pykettk. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
@magento run Sample Data Tests CE, Sample Data Tests EE, Sample Data Tests B2B |
Failed to run the builds. Please try to re-run them later. |
@magento run all tests |
The failing tests do not appear to be related to these proposed changes. |
@magento create issue |
Description (*)
The
updateDesignParams()
function has the capacity to throw theUnexpectedValueException
but this is not documented in either of the functions that call it. Additionally, thecreateAsset()
function has the potential to throw aLocalizedException
which is not documented by either of the functions that make use of it.Manual testing scenarios (*)
Contribution checklist (*)
Resolved issues: