[2.4] Add support for missing Curl methods to the Curl client

[lbajsarowicz]

Description (*)

Cherry-picked change from #39330 rated as "backwards-incompatible" by @engcom-Dash rejecting all the changes to Testing Framework, leaving just the new methods in the Curl class.

It makes me upset that after spending hours to get the previous PR in shape to merge, this bug fix was taken down instead of recommendation to fix imaginary "backwards incompatiblity", provided Maintainers can point what change became backwards-incompatible.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @lbajsarowicz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[lbajsarowicz]

@magento run all tests

[lbajsarowicz]

@magento run all tests (after changing the method to pass payloads)

[magento-automated-testing]

Failed to run the builds. Please try to re-run them later.

[bgorski]

@magento run all tests

[lbajsarowicz]

@magento run all tests

I simplified the delete method signature to make the method compatible to the Magento\TestFramework, which - according to @engcom-Dash (in #39330) has higher priority than Magento\Framework.

[bgorski]

@lbajsarowicz there's a bug in here - it uses $params for makeRequest but is not receiving any in the method head, there's only $uri there.

[lbajsarowicz]

Nice catch. I'm handling it.

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

Hello @lbajsarowicz,

Thanks for the contribution!

Please have a look at the below review comments.

Thanks

[engcom-Hotel]

Add void as the function return type

Suggested change

	public function delete($uri)
	public function delete($uri): void

[engcom-Hotel]

As per the documentation, delete method might have Payload. So I think we can add $params as an optional variable. I think here @bgorski is just pointing out that we are not passing $params but using it in the makeRequest method.