Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_beforeToHtml DocBlock return type $this instead of string #39490

Open
wants to merge 3 commits into
base: 2.4-develop
Choose a base branch
from
Open

_beforeToHtml DocBlock return type $this instead of string #39490

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2c122a
_beforeToHtml method DocBlock change with $this instead of string
lucafuser Dec 17, 2024
ab62144
Merge branch '2.4-develop' into checkout-success-docblock
engcom-Hotel Jan 23, 2025
406573b
Fix static test error reporting
lucafuser Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions app/code/Magento/Checkout/Block/Onepage/Success.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
* Copyright 2024 Adobe
* All Rights Reserved.
*/
namespace Magento\Checkout\Block\Onepage;

Expand Down Expand Up @@ -65,7 +65,7 @@ public function getAdditionalInfoHtml()
/**
* Initialize data and prepare it for output
*
* @return string
* @return $this
*/
protected function _beforeToHtml()
{
Expand Down Expand Up @@ -127,6 +127,8 @@ protected function canViewOrder(Order $order)
}

/**
* Get continue url
*
* @return string
* @since 100.2.0
*/
Expand Down