Magento\Framework\Filesystem\Driver\Http::isExists - Removed "OK" phrase check

[ajith107]

Description (*)

• Removed the OK phrase from the condition check
• Updated the Unit test data provider

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes - Magento\Framework\Filesystem\Driver\Http depends on reason phrase OK #39546

Manual testing scenarios (*)

1. Tested & verified the fix in the local Magento setup

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @ajith107. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[ajith107]

Close & reopen the PR after singing the Adobe CLA

[ajith107]

@adobe/open-source-office I have just singed the Adobe CLA. However It's not getting reflected in my PR

[ajith107]

Close & reopen after signing Adobe CLA

[ajith107]

@magento run all tests

[ajith107]

@magento run Static Tests

[engcom-Charlie]

Hi @ajith107,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

• Install fresh Magento 2.4-develop

Steps to reproduce

• Created script to check the Magento\Framework\Filesystem\Driver\Http::isExists()

Before: ✖️ 
Previously https://acs4.editionguard.com/fulfillment/URLLink.acsm url was giving "File does not exist" on "HTTP/1.1 200"

After: ✔️
Getting "File exists" on "HTTP/1.1 200"

The build is not successful, its failing. Hence, moving this PR to Extended Testing.

Thanks.

[engcom-Charlie]

@magento run all tests

[engcom-Charlie]

@magento run all tests

[engcom-Charlie]

@magento run Unit Tests

[engcom-Charlie]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

[engcom-Charlie]

Three of the Functional B2B test failure are inconsistent in the last two builds. They neither part of PR nor failing because of the PR changes, seems to be flaky. The other one is a known issue. Hence moving it to Merge In Progress.

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39558/f5c74c8dcd08c015142e6a1938d94dff/Functional/allure-report-b2b/index.html#categories

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39558/4cc21cf0db1345bcf8d80ffcb457eeb6/Functional/allure-report-b2b/index.html#categories/ff086893d1b2f6d93d2b926c3d303ab7/a2de8455510f6b0c/

Known Issue:
AdminQuoteLevelPercentDiscountNotRemovedWhenDiscountCanBeDistributedTest: ACQE-7594