fix(usps): remove duplicate <price_type> node breaking config XML merge (#40779)#40828
Open
lbajsarowicz wants to merge 1 commit into
Open
fix(usps): remove duplicate <price_type> node breaking config XML merge (#40779)#40828lbajsarowicz wants to merge 1 commit into
lbajsarowicz wants to merge 1 commit into
Conversation
vendor/magento/module-usps/etc/config.xml shipped two sibling <price_type> nodes (EPS and COMMERCIAL) under <carriers><usps>. Magento's Dom config reader rejects sibling elements with the same tag name and throws "More than one node matching the query: /config/default/carriers/usps/price_type" during any config merge. EPS is not a valid price_type value (the price_type dropdown source exposes only COMMERCIAL and RETAIL; EPS is an account_type). Keep the canonical COMMERCIAL value as the single default. Fixes magento#40779
|
Hi @lbajsarowicz. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
Contributor
Author
|
@magento run all tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
app/code/Magento/Usps/etc/config.xmlshipped two sibling<price_type>nodes(
EPSandCOMMERCIAL) under<carriers><usps>. Magento'sDomconfig readerrejects sibling elements with the same tag name and throws
More than one node matching the query: /config/default/carriers/usps/price_typeduring any config merge (any custom module overriding a USPS carrier value
triggers it, as does
bin/magento cache:clean).EPSis not a validprice_typevalue — the dropdown source(
Magento\Usps\Model\Config\Source\PriceType) only exposesCOMMERCIALand
RETAIL;EPSis an account type. Kept the canonicalCOMMERCIALdefault.Fixes #40779
Fixed Issues
<price_type>node in quality patch AC-15210 breaks config XML merge #40779: Duplicate<price_type>node in quality patch AC-15210 breaks config XML mergeManual testing scenarios
<carriers><usps><price_type>inetc/config.xml.bin/magento cache:clean.main.ERROR: More than one node matching the query: /config/default/carriers/usps/price_type. After: cache clears cleanly.Contribution checklist