Add queue consumers start chain command#40840
Open
Sam-Mear wants to merge 1 commit into
Open
Conversation
|
Hi @Sam-Mear. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
Author
|
@magento run all tests |
Contributor
|
@magento create issue |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
bin/magento queue:consumers:start-chaincommand.Description (*)
This allows you to run many specified queue consumers in one command, without manually running each.
I've split the cron running up into two parts:
app/code/Magento/MessageQueue/Model/Cron/ConsumersRunner.phpandapp/code/Magento/MessageQueue/Model/ConsumersRunnerExecutor.php. This allows to make the other command to chain queue consumers.The problem it solves
One of our clients is hosted on PlatformSH. PlatformSH won't work with the queue consumers running in the cron: https://github.com/platformsh-templates/magento2ce/blob/master/deploy.php#L136
Issue is, the worker runs async.operations.all, which seems to require a queue connection which we don't have, but we require DB queues to still work. With this, We can safely run the same cron runner, that works for us without a queue connection through a worker that wont break platformsh.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Pretty minimal, but run test with crons and running the new command,
Questions or comments
Contribution checklist (*)
Resolved issues: