Fix PHP 8.5: KEY_MYSQL_SSL_VERIFY hardcoded as 1014 collides with ren…#40849
Open
shlrkb wants to merge 1 commit into
Open
Fix PHP 8.5: KEY_MYSQL_SSL_VERIFY hardcoded as 1014 collides with ren…#40849shlrkb wants to merge 1 commit into
shlrkb wants to merge 1 commit into
Conversation
…amed Pdo\Mysql constant PHP 8.5 removed ATTR_SERVER_PUBLIC_KEY, shifting all Pdo\Mysql constant values down by one. KEY_MYSQL_SSL_VERIFY was hardcoded as 1014 (a legacy workaround for PHP 7.1.3 support) which now maps to ATTR_LOCAL_INFILE_DIRECTORY instead of ATTR_SSL_VERIFY_SERVER_CERT, causing every Magento 2.4.9 installation on PHP 8.5 to crash on boot with an open_basedir error. Apply the same PHP_VERSION_ID >= 80400 pattern already used for KEY_MYSQL_SSL_KEY, KEY_MYSQL_SSL_CERT and KEY_MYSQL_SSL_CA.
|
Hi @shlrkb. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
Contributor
|
@magento create issue |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…amed Pdo\Mysql constant
PHP 8.5 removed ATTR_SERVER_PUBLIC_KEY, shifting all Pdo\Mysql constant values down by one. KEY_MYSQL_SSL_VERIFY was hardcoded as 1014 (a legacy workaround for PHP 7.1.3 support) which now maps to ATTR_LOCAL_INFILE_DIRECTORY instead of ATTR_SSL_VERIFY_SERVER_CERT, causing every Magento 2.4.9 installation on PHP 8.5 to crash on boot with an open_basedir error.
Apply the same PHP_VERSION_ID >= 80400 pattern already used for KEY_MYSQL_SSL_KEY, KEY_MYSQL_SSL_CERT and KEY_MYSQL_SSL_CA.
Description (*)
PHP 8.5 removed Pdo\Mysql::ATTR_SERVER_PUBLIC_KEY, shifting all constant integer values down by one. KEY_MYSQL_SSL_VERIFY was hardcoded as 1014 (legacy workaround for PHP 7.1.3). On PHP 8.5, 1014 is now ATTR_LOCAL_INFILE_DIRECTORY which expects a path — passing false crashes every installation on boot with an open_basedir PDOException.
Applies the same PHP_VERSION_ID >= 80400 pattern already used for KEY_MYSQL_SSL_KEY, KEY_MYSQL_SSL_CERT and KEY_MYSQL_SSL_CA.
Related Pull Requests
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)
Resolved issues: