Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test pull request for AWS zubair #4209

Closed
wants to merge 158 commits into from
Closed

test pull request for AWS zubair #4209

wants to merge 158 commits into from

Conversation

glo80684
Copy link
Collaborator

Description

TODO: Describe your changes in detail here.

Related Issue

Closes #ISSUE_NUMBER.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

huykon and others added 30 commits December 15, 2022 09:19
@huykon
fix: Homepage slider creates unexpected GET-requests
9e009a9
@huykon
fix: only query background image when have value
4a8ed62
@devops-pwa-codebuild
v13.0.0
83c8980
@dpatil-magento
Merge branch 'develop' into fix/3762
f3e1330
@Sahilsks
checkbox clickable label working
0ffb79c
@Sahilsks
prettier
15d8ed6
@RaghavendraTirumalasetti
BUG#PWA-3065 When the button sign in is pressed by the keyboard, noth…
ee0bb78 
…ing happens
@RaghavendraTirumalasetti
Merge branch 'develop' into BUG#PWA-3065
2195dcb
@RaghavendraTirumalasetti
BUG#PWA-3065 When the button sign in is pressed by the keyboard, noth…
fb307c6 
…ing happens
@RaghavendraTirumalasetti
Merge branch 'BUG#PWA-3065' of github.com:glo71317/pwa-studio into BU…
d492d9d 
…G#PWA-3065
@rafaelstz
Adding Dev Container config
97cf588
@RaghavendraTirumalasetti
BUG#-3064 When the button cancel beside create account is pressed by …
b257488 
…the keyboard, nothing happens
@RaghavendraTirumalasetti
Merge branch 'develop' into BUG#PWA-3064
9b634c4
@RaghavendraTirumalasetti
BUG#-3064 When the button cancel beside create account is pressed by …
8304fe9 
…the keyboard, nothing happens
@RaghavendraTirumalasetti
Merge branch 'BUG#PWA-3064' of github.com:glo71317/pwa-studio into BU…
d694740 
…G#PWA-3064
@RaghavendraTirumalasetti
BUG#-3064 When the button cancel beside create account is pressed by …
9c0da74 
…the keyboard, nothing happens
@glo82145 @dpatil-magento
PWA-3052::Page Builder column-line content type is not supported, thi…
72a2627 
…s content will not be rendered (#4028)

Co-authored-by: Devagouda <[email protected]>
@RaghavendraTirumalasetti
Merge branch 'develop' into BUG#PWA-3065
b32fe9e
@RaghavendraTirumalasetti
Merge branch 'develop' into BUG##PWA-3055
3abbb96
@glo82145
Merge branch 'develop' into BUG#PWA-3025
6fb897a
@RaghavendraTirumalasetti
BUG##PWA-3063 No proper screen reader announcements are for the optio…
f0bfaad 
…ns related to size
@RaghavendraTirumalasetti
Merge branch 'develop' into BUG##PWA-3063
e5723e1
@RaghavendraTirumalasetti
BUG##PWA-3063 No proper screen reader announcements are for the optio…
49df6d8 
…ns related to size
@RaghavendraTirumalasetti
Merge branch 'BUG##PWA-3063' of github.com:glo71317/pwa-studio into B…
49f0d30 
…UG##PWA-3063
@glo82145
PWA-3049::[PWA] Internal Page Builder links with query part
d3e8987
@glo82145
Merge branch 'develop' into PWA-3049
455e913
@glo82145
PWA-3071::Graphql Cart > Prices > Discounts array also including Gift… (
9e9b78e 
#4052)

* PWA-3071::Graphql Cart > Prices > Discounts array also including Gift Cards in 2.4.6

* PWA-3071::Graphql Cart > Prices > Discounts array also including Gift Cards in 2.4.6
@glo42707
Merge branch 'develop' into BUG##PWA-3055
648e5a3
@glo42707
Merge branch 'develop' into BUG#PWA-3025
35b0b33
@RaghavendraTirumalasetti
Merge branch 'develop' into BUG#PWA-3065
7f44dba
@glo80684
Copy link
Collaborator Author

run lighthouse-desktop

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Nov 30, 2023 •
edited
Loading

Fails
🚫 A version label is required. A maintainer must add one.
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.
🚫 Missing information in PR. Please fill out the "Description" section.
Warnings
⚠️ Found the word "TODO" in the PR description. Just letting you know incase you forgot :)
Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against 52229b2

@dpatil-magento
Copy link
Contributor

run lighthouse-desktop

@glo42707
Copy link
Contributor

glo42707 commented Dec 4, 2023

closing it since itwas just raised for testing by devops team

@glo42707 glo42707 closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs triage pkg:babel-preset-peregrine pkg:create-pwa pkg:extensions pkg:pagebuilder pkg:peregrine pkg:pwa-buildpack pkg:venia-concept pkg:venia-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.