Skip to content

Conversation

glo82145
Copy link
Collaborator

@glo82145 glo82145 commented Oct 7, 2025

Description

TODO: Describe your changes in detail here.

Related Issue

Closes #ISSUE_NUMBER.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Oct 7, 2025

Fails
🚫 Lighthouse assertions failed 😔. All assertions must pass before this PR can be merged
https://pr-4560.pwa-venia.com/

categories.pwa (auditRan)

  • Expected: 1
  • Actual: 0
  • Result: Failed

Max Potential First Input Delay (maxNumericValue)

  • Expected: 520
  • Actual: 582
  • Result: Failed
  • Docs link: https://developer.chrome.com/docs/lighthouse/performance/lighthouse-max-potential-fid/
https://pr-4560.pwa-venia.com/venia-tops.html?page=1

categories.pwa (auditRan)

  • Expected: 1
  • Actual: 0
  • Result: Failed

Max Potential First Input Delay (maxNumericValue)

  • Expected: 520
  • Actual: 582
  • Result: Failed
  • Docs link: https://developer.chrome.com/docs/lighthouse/performance/lighthouse-max-potential-fid/
https://pr-4560.pwa-venia.com/valeria-two-layer-tank.html

categories.pwa (auditRan)

  • Expected: 1
  • Actual: 0
  • Result: Failed
https://pr-4560.pwa-venia.com/search.html?query=tops&page=1

categories.pwa (auditRan)

  • Expected: 1
  • Actual: 0
  • Result: Failed
🚫

node failed.

Log

ERROR ON TASK: lighthouseTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results-f823c674.json

Generated by 🚫 dangerJS against 31015b6

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Oct 7, 2025

Fails
🚫

node failed.

🚫

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • displays assigned products:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="CategoryContent-root"] [data-cy="GalleryItem-name"], [data-cy="SearchPage-root"] [data-cy="GalleryItem-name"]`, but never found it.
    ,shows products specific to the categories in the different store:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="CategoryContent-root"] [data-cy="GalleryItem-name"], [data-cy="SearchPage-root"] [data-cy="GalleryItem-name"]`, but never found it.
    ,lets users add products to cart regardless of store view:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="CategoryContent-root"] [data-cy="GalleryItem-root"]`, but never found it.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 31015b6

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Oct 7, 2025

Fails
🚫

node failed.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 31015b6

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Oct 7, 2025

Fails
🚫

node failed.

🚫 A version label is required. A maintainer must add one.
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.

🚫 Missing information in PR. Please fill out the "Description" section.
🚫

The following file(s) were not formatted with prettier. Make sure to execute yarn run prettier locally prior to committing.

packages/pwa-buildpack/lib/WebpackTools/targetables/TargetableSet.js
Warnings
⚠️ Found the word "TODO" in the PR description. Just letting you know incase you forgot :)
Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: prettierCheck


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against 31015b6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants