V1: Add layout to fingerprint to enable layout-level Magewire components#147
Open
gerrits-ecommerce wants to merge 2 commits intomagewirephp:1.xfrom
Open
Conversation
Author
|
As Willem and I already discussed on the Hyva Slack I'm not 100% sure what the performance impact of this change will be. My local testing seems to indicate the impact is minimal to none. But if anyone with more expertise in this area has additional input I'd be happy to hear that. |
wpoortman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to define a Magewire component in a page_layout file, configure a category (or CMS page, etc.) to use this layout file, and have the component function as expected.
This functionality can be tested using the module below:
reproduction.zip
In the current Magewire codebase; if you configure a category to use the test layout that this module defines and load that category the initial render will succeed, but any changes will result in a 404 error because the Magewire Module cannot be found in the default catalog_category_view template.
With this change the module will function.