This repository was archived by the owner on Aug 7, 2026. It is now read-only.
Characterize shared ornate UI behavior before extraction - #52
Open
magicalfeyfenny wants to merge 17 commits into
Open
Characterize shared ornate UI behavior before extraction#52magicalfeyfenny wants to merge 17 commits into
magicalfeyfenny wants to merge 17 commits into
Conversation
lol lmao my usage credits are dying
commit f034094 Author: magicalfeyfenny <magicalfeyfenny@fenny.moe> Date: Sun Jul 12 10:18:31 2026 -0700 i had codex do a bunch of random shit lol lol lmao my usage credits are dying commit ae3507b Author: magicalfeyfenny <magicalfeyfenny@fenny.moe> Date: Sat Jul 11 07:49:11 2026 -0700 Polish player movement and firing feel
Polish player movement and firing feel
Overhaul boss variety and character encounters
…overhaul Rebuild lush 3D stages and add the sisters' grand finale
* Add refractive crystal UI panels * Darken crystal UI for readability * Tint crystal UI with a midnight gradient * Run GameMaker unit tests in GitHub Actions * Use current GitHub Actions runtimes * Use feed-available GameMaker runtime in CI * Avoid spaces in GameMaker CI user path * Use GameMaker LTS 2026 tooling in CI * Use absolute GameMaker project path in CI * Fix LTS PS4 option schema
This was referenced Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Characterize the existing behavior of the shared ornate UI helpers before changing their production ownership.
This milestone records the visual constants, layout rules, argument behavior, and caller-visible draw-state postconditions relied upon by the title, story, gameplay HUD, practice, pause, and boss presentation systems.
The resulting coverage establishes a behavior-preservation boundary for the dedicated ornate UI extraction.
Part of #28.
Enables #50.
Scope
This PR:
The frozen characterization candidate is:
acdf8e529ffe68e38fb87580c73ca5cee2286f6dNon-goals
This PR does not move the ornate UI helpers or add
scr_ui_ornate.It does not rename functions, alter callers, change argument defaults, introduce compatibility facades, normalize draw state, redesign the UI, or intentionally change rendering behavior.
It does not modify gameplay logic, story content, persistence, input handling, audio behavior, RNG behavior, balance, save data, or release configuration.
It does not begin the extraction tracked by #50 or authorize any later structural-decomposition milestone.
Risk
Risk is standard.
The principal risk is incorrectly encoding incidental or misunderstood behavior as a required compatibility contract. The characterization tests therefore document observable production behavior without claiming that every existing side effect is desirable permanently.
Validation
Validation was completed against candidate:
acdf8e529ffe68e38fb87580c73ca5cee2286f6dEvidence:
29889767822passed all 134 registered tests.29889883786completed all eight selected captures.Any conflict resolution, rebase, merge, or additional commit that changes the frozen candidate requires fresh focused validation against the final PR head.
Rollback
Before merge, rollback consists of closing this PR and preserving the frozen characterization branch and candidate SHA for reference.
After merge, rollback can be performed through an ordinary revert pull request removing the six characterization tests and restoring the previous planning and ownership documentation.
Rollback does not require rewriting branch history or modifying production GameMaker resources.
Independent agent review
Independent review should verify that:
The final machine-readable pull-request contract and reviewer attestations must be populated after the pull-request number and exact base and head SHAs are known.