Skip to content

feat: downstream foldable intent import - #190

Open
jonasXchen wants to merge 1 commit into
mainfrom
feat/downstream-foldableintent-import
Open

feat: downstream foldable intent import#190
jonasXchen wants to merge 1 commit into
mainfrom
feat/downstream-foldableintent-import

Conversation

@jonasXchen

@jonasXchen jonasXchen commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Refactor
    • Commit and CommitAndUndelegate intent builders now include three new public inherent methods: build(), build_and_invoke(), and build_and_invoke_signed(). These changes expose build and invoke functionality directly on the builder types. The public API surface has been extended to provide more convenient access to these operations.

@jonasXchen
jonasXchen requested a review from taco-paco April 17, 2026 09:29
@coderabbitai

coderabbitai Bot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: c8b96a96-3a52-41e8-9c75-8996336d79f7

📥 Commits

Reviewing files that changed from the base of the PR and between df2c561 and 856fef5.

📒 Files selected for processing (2)
  • rust/sdk/src/ephem/cau_intent_builder.rs
  • rust/sdk/src/ephem/commit_intent_builder.rs

📝 Walkthrough

Walkthrough

The pull request adds inherent methods to two builder classes in the Rust SDK's ephemeral module. The CommitAndUndelegateIntentBuilder and CommitIntentBuilder classes each receive three new public methods: build(), build_and_invoke(), and build_and_invoke_signed(). These methods forward directly to their corresponding implementations in the FoldableIntentBuilder trait. The changes include necessary imports for IntentInstructions and ProgramResult. The underlying implementation logic remains unchanged; only the callable API surface is modified to provide direct access to these methods without requiring trait imports.

Suggested reviewers

  • taco-paco
  • GabrielePicco
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/downstream-foldableintent-import

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@taco-paco taco-paco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That defeats the purpose of Foldable builders, let's see a better solution. Additionally, build_and_invoke should be supported for ActionBuilder as well.
This highlight how much boilerplate there will be without Foldable traits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants