-
Notifications
You must be signed in to change notification settings - Fork 37
feat: update to legacy SDK #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,11 +22,16 @@ custom-panic = [] | |
|
|
||
| [dependencies] | ||
| anchor-lang = { version = "1.0.2", features = ["init-if-needed"] } | ||
| ephemeral-rollups-sdk = { version = "0.16.2", features = ["anchor"] } | ||
| # TODO: Remove this once the SDK is published to crates.io | ||
| ephemeral-rollups-sdk = { git = "https://github.com/magicblock-labs/ephemeral-rollups-sdk.git", rev = "0fc4604157de51df28693e02e5a1a6a4a08c8a03", features = [ | ||
| "anchor", | ||
| "crank", | ||
| ] } | ||
| sha2 = "0.10" | ||
| magicblock-magic-program-api = { version = "0.10.1", default-features = false } | ||
| bincode = "^1.3" | ||
|
Comment on lines
+25
to
31
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🔵 Trivial | 💤 Low value 🧩 Analysis chain🏁 Script executed: #!/bin/bash
rg -n 'magicblock_magic_program_api|bincode::|sha2::|MagicBlockInstruction|invoke_signed' crank-counter/anchor/programs/crank-counter/src/lib.rsRepository: magicblock-labs/magicblock-engine-examples Length of output: 180 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "== Cargo.toml =="
nl -ba crank-counter/anchor/programs/crank-counter/Cargo.toml | sed -n '1,120p'
echo
echo "== Search entire crate for relevant symbols =="
rg -n 'magicblock_magic_program_api|bincode::|sha2::|MagicBlockInstruction|invoke_signed|magic_context|MAGIC_CONTEXT_ID' crank-counter/anchor/programs/crank-counter
echo
echo "== File list =="
git ls-files crank-counter/anchor/programs/crank-counterRepository: magicblock-labs/magicblock-engine-examples Length of output: 237 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "== Cargo.toml =="
cat -n crank-counter/anchor/programs/crank-counter/Cargo.toml | sed -n '1,120p'
echo
echo "== Search entire crate for relevant symbols =="
rg -n 'magicblock_magic_program_api|bincode::|sha2::|MagicBlockInstruction|invoke_signed|magic_context|MAGIC_CONTEXT_ID' crank-counter/anchor/programs/crank-counter
echo
echo "== File list =="
git ls-files crank-counter/anchor/programs/crank-counterRepository: magicblock-labs/magicblock-engine-examples Length of output: 1576 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "== lib.rs (top section) =="
cat -n crank-counter/anchor/programs/crank-counter/src/lib.rs | sed -n '1,180p'
echo
echo "== Search whole repo for removed crate name =="
rg -n 'magicblock_magic_program_api|magicblock-magic-program-api' .
echo
echo "== Search whole repo for sha2/bincode usage in this crate =="
rg -n '\bsha2\b|\bbincode\b' crank-counter/anchor/programs/crank-counterRepository: magicblock-labs/magicblock-engine-examples Length of output: 10675 Remove the unused 🤖 Prompt for AI Agents |
||
|
|
||
|
|
||
| [lints.rust] | ||
| unexpected_cfgs = { level = "warn", check-cfg = ['cfg(target_os, values("solana"))'] } | ||
| unexpected_cfgs = { level = "warn", check-cfg = [ | ||
| 'cfg(target_os, values("solana"))', | ||
| ] } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash cat crank-counter/anchor/Anchor.tomlRepository: magicblock-labs/magicblock-engine-examples
Length of output: 593
🏁 Script executed:
Repository: magicblock-labs/magicblock-engine-examples
Length of output: 860
🏁 Script executed:
Repository: magicblock-labs/magicblock-engine-examples
Length of output: 830
🏁 Script executed:
Repository: magicblock-labs/magicblock-engine-examples
Length of output: 8114
🏁 Script executed:
Repository: magicblock-labs/magicblock-engine-examples
Length of output: 4589
Update
[programs.localnet]to the new program ID. It still points toFW2QPnTK9WwYLNG29GhH7PGYdp7Jwq3pGQrUuNdUnK44whiledeclare_id!and[programs.devnet]use6avjV8kWVhVf2NX6ZeE7SaqyqjRnCD6JDwhiUH6yFymz.🤖 Prompt for AI Agents