fix(metrics): attribute simulation fetches - #1502
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughAdds a Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2ac3bea to
24acbd6
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2ac3bea2f7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
24acbd6 to
4ce35f0
Compare
Summary
Attribute account fetches needed to simulate a transaction to a dedicated
simulate_transactionmetrics entrypoint rather thansend_transaction.Details
Simulation account ensuring now preserves its own request origin through the existing account-fetch context. This separates simulation-driven fetch, clone, pending-work, and companion-fetch observability from submitted transactions without changing transaction preparation, account ordering, primary-mode checks, replay handling, or simulation responses.
The new entrypoint is a static, bounded Prometheus label value. Transaction signatures remain tracing-only and are not labels.
Example PromQL for simulation-owned fetch activity over five minutes:
The change adds metrics-level coverage and Aperture simulation tests to verify the new attribution while retaining existing send-transaction behavior.
Summary by CodeRabbit
simulateTransactionaccount and ledger fetching by using the correct request context.