Simplifies repository listing methods and tests #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames repository listing methods by removing the redundant "PaginatedAsync" suffix, resulting in cleaner and more consistent naming across the application.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies repository method naming by removing the redundant "PaginatedAsync" suffix from method names, resulting in cleaner and more consistent naming. The refactoring affects repository interfaces and implementations, along with comprehensive test reorganization.
- Renamed repository methods:
ListThreadPreviewsPaginatedAsync→ListThreadPreviewsAsync,SearchPostsPaginatedAsync→SearchPostsAsync,ListPostsPaginatedAsync→ListPostsAsync, andListBansPaginatedAsync→ListBansAsync - Reorganized integration tests into more focused test classes with better structure
- Enhanced test data builder with new helper methods
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Hikkaba.Infrastructure.Repositories/Contracts/IThreadRepository.cs | Renamed ListThreadPreviewsPaginatedAsync to ListThreadPreviewsAsync in interface |
| Hikkaba.Infrastructure.Repositories/Contracts/IPostRepository.cs | Renamed SearchPostsPaginatedAsync to SearchPostsAsync and ListPostsPaginatedAsync to ListPostsAsync in interface |
| Hikkaba.Infrastructure.Repositories/Contracts/IBanRepository.cs | Renamed ListBansPaginatedAsync to ListBansAsync in interface |
| Hikkaba.Infrastructure.Repositories/Implementations/ThreadRepository.cs | Updated method implementation and logic to support IncludeDeleted filter option |
| Hikkaba.Infrastructure.Repositories/Implementations/PostRepository.cs | Updated method implementations to match new naming |
| Hikkaba.Infrastructure.Repositories/Implementations/BanRepository.cs | Updated method implementation to match new naming |
| Hikkaba.Application/Implementations/ThreadService.cs | Updated repository method calls, but service interface method name not updated |
| Hikkaba.Application/Implementations/PostService.cs | Updated repository method calls, but service interface method names not updated |
| Hikkaba.Application/Implementations/BanService.cs | Updated repository method call, but service interface method name not updated |
| Hikkaba.Tests.Integration/Tests/Repositories/ThreadRepositoryTests.cs | Removed old test file |
| Hikkaba.Tests.Integration/Tests/Repositories/Thread/ListThreadPreviewsTests.cs | Added new comprehensive test file with 28 focused test scenarios |
| Hikkaba.Tests.Integration/Tests/Repositories/Post/SearchPostsTests.cs | Reorganized test file with namespace and class name changes |
| Hikkaba.Tests.Integration/Tests/Repositories/Ban/ListBansTests.cs | Reorganized test file with namespace and class name changes |
| Hikkaba.Tests.Integration/Builders/ThreadTestDataBuilder.cs | Enhanced with WithThreadAndOp, improved WithCategory parameters, and fixed UpdateThreadLastBumpAt to respect bump limits |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 23 out of 23 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames repository listing methods by removing the redundant
"PaginatedAsync" suffix, resulting in cleaner and more
consistent naming across the application.