use short OrderByItem syntax #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the codebase to use a more concise syntax for creating OrderByItem instances by leveraging a new constructor and implicit string conversion operator.
Key Changes:
- Added a constructor to
OrderByItemthat accepts field name and optional direction parameters - Updated all usages to use the shorter syntax:
new(field, direction)instead of object initializer syntax - Leveraged implicit string-to-OrderByItem conversion where only ascending order is needed
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Hikkaba.Paging/Models/OrderByItem.cs | Added parameterized constructor and made Field property required to support concise initialization |
| Hikkaba.Web/Controllers/Mvc/PostController.cs | Updated OrderByItem creation to use new constructor syntax |
| Hikkaba.Web/Controllers/Mvc/HomeController.cs | Updated to use constructor syntax and implicit string conversion for simpler cases |
| Hikkaba.Web/Controllers/Mvc/CategoryController.cs | Refactored OrderByItem initialization to use constructor syntax |
| Hikkaba.Web/Controllers/Mvc/Admin/BanAdminController.cs | Updated to use shorter constructor-based syntax |
| Hikkaba.Tests.Integration/Tests/Repositories/Post/ListThreadPostsTests.cs | Simplified test setup using implicit string conversion for ascending order |
| Hikkaba.Paging.Tests.Unit/OrderByProjectionConfiguratorTests/AppendTests.cs | Updated test cases to use implicit string conversion |
| Hikkaba.Paging.Tests.Unit/FilterTests/SkipBasedPagingFilterTests.cs | Simplified OrderByItem creation in tests |
| Hikkaba.Paging.Tests.Unit/FilterTests/PageBasedPagingFilterTests.cs | Updated to use collection expression with implicit conversion |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.