Add validation of organisasjonsnummer, with tests - #3
Open
perchrh wants to merge 2 commits into
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 94 94
=====================================
Hits 94 94Continue to review full report at Codecov.
|
Owner
|
Hi! This looks great! I will take a closer look and merge later :-) Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
if you want it, you can add support for organisasjonsnummer to your module.
Perhaps the name of the module should change, as well, then, to "Offentlig idnummer" / "Norwegian National ID numbers" or similar.
I needed this code myself, in order to validate both orgnr and fnr, and share the additions with you.