bump to v4.58

.github/ISSUE_TEMPLATE/Feature_Request.yml

@@ -57,4 +57,4 @@ body:
 
         Are there any other GitHub issues (open or closed) or pull requests that should be linked here? Vendor blog posts or documentation? For example:
 
-        * https://azure.microsoft.com/en-us/roadmap/virtual-network-service-endpoint-for-azure-cosmos-db/
+        * https://azure.microsoft.com/en-us/updates?id=general-availability-azure-cosmos-db-virtual-network-service-endpoint

.github/labeler-issue-triage.yml

@@ -221,12 +221,6 @@ service/management-groups:
 service/maps:
   - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_maps_((.|\n)*)###'
 
-service/mixed-reality:
-  - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_spatial_anchors_account((.|\n)*)###'
-
-service/mobile-network:
-  - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_mobile_network((.|\n)*)###'
-
 service/mongo-cluster:
   - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_mongo_cluster((.|\n)*)###'
 
@@ -291,11 +285,14 @@ service/redhatopenshift:
   - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_redhat_openshift_cluster((.|\n)*)###'
 
 service/redis:
-  - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_(redis_cache\W+|redis_cache_access_policy\W+|redis_cache_access_policy_assignment\W+|redis_enterprise_cluster\W+|redis_enterprise_database\W+|redis_firewall_rule\W+|redis_linked_server\W+|resource_deployment_script_azure_cli\W+|resource_deployment_script_azure_power_shell\W+|resource_management_private_link\W+|resource_management_private_link_association\W+|resource_provider_registration\W+)((.|\n)*)###'
+  - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_(managed_redis|redis_)((.|\n)*)###'
 
 service/relay:
   - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_relay_((.|\n)*)###'
 
+service/resource:
+  - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_(management_group_template_deployment\W+|management_lock\W+|resource_deployment_script_azure_cli\W+|resource_deployment_script_azure_power_shell\W+|resource_group\W+|resource_group_template_deployment\W+|resource_management_private_link\W+|resource_management_private_link_association\W+|resource_provider_registration\W+|resources|subscription_template_deployment|template_spec_version|tenant_template_deployment)((.|\n)*)###'
+
 service/search:
   - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_search_s((.|\n)*)###'
 

.github/labeler-pull-request-triage.yml

@@ -369,16 +369,6 @@ service/maps:
   - any-glob-to-any-file:
     - internal/services/maps/**/*
 
-service/mixed-reality:
-- changed-files:
-  - any-glob-to-any-file:
-    - internal/services/mixedreality/**/*
-
-service/mobile-network:
-- changed-files:
-  - any-glob-to-any-file:
-    - internal/services/mobilenetwork/**/*
-
 service/mongo-cluster:
 - changed-files:
   - any-glob-to-any-file:
@@ -487,6 +477,7 @@ service/redhatopenshift:
 service/redis:
 - changed-files:
   - any-glob-to-any-file:
+    - internal/services/managedredis/**/*
     - internal/services/redis/**/*
     - internal/services/redisenterprise/**/*
 
@@ -495,6 +486,11 @@ service/relay:
   - any-glob-to-any-file:
     - internal/services/relay/**/*
 
+service/resource:
+- changed-files:
+  - any-glob-to-any-file:
+    - internal/services/resource/**/*
+
 service/search:
 - changed-files:
   - any-glob-to-any-file:

.github/workflows/depscheck.yaml

@@ -23,8 +23,10 @@ jobs:
       - run: bash scripts/gogetcookie.sh
       - run: make depscheck
   save-artifacts-on-fail:
-    if: ${{ needs.depscheck.result }} == 'failure'
+    needs: depscheck
+    if: ${{ failure() }}
     uses: ./.github/workflows/save-artifacts.yaml
   comment-on-fail:
-    if: ${{ needs.depscheck.result }} == 'failure'
+    needs: depscheck
+    if: ${{ failure() }}
     uses: ./.github/workflows/comment-failure.yaml

.github/workflows/document-lint.yaml

@@ -19,13 +19,30 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+        with:
+          fetch-depth: 2
       - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
         with:
           go-version-file: ./.go-version
       - run: bash scripts/gogetcookie.sh
-      - run: make document-lint
-        continue-on-error: true
-      - name: check lint result
-        if: failure()
+      - name: Get changed files
+        id: changed-files
+        run: |
+          changed=$(git diff --name-only HEAD^1 HEAD -- internal/services | sed "s|^|${{ github.workspace }}/|" | tr '\n' ',' | sed 's/,$//')
+          changed=${changed:-}
+          echo "::notice::check with files: ${changed}"
+          echo "FILE_LIST=$changed" >> $GITHUB_ENV
+          echo "has-files=$([ -n "$changed" ] && echo 'true' || echo 'false')" >> $GITHUB_OUTPUT
+
+      - name: run document lint checker
+        if: steps.changed-files.outputs.has-files == 'true'
         run: |
-            echo "::warning::Document linting failed. Please fix the issues."
+          if make document-lint; then
+            echo "::notice::Document lint success."
+          else
+            echo "::warning::Document lint failed. Please fix the issues."
+          fi
+
+      - name: skip document lint checker
+        if: steps.changed-files.outputs.has-files == 'false'
+        run: echo "::notice::No internal/services files changed, skipping resource document lint check"

.github/workflows/gencheck.yaml

@@ -26,8 +26,10 @@ jobs:
       - run: bash scripts/gogetcookie.sh
       - run: make gencheck
   save-artifacts-on-fail:
-    if: ${{ needs.gencheck.result }} == 'failure'
+    needs: gencheck
+    if: ${{ failure() }}
     uses: ./.github/workflows/save-artifacts.yaml
   comment-on-fail:
-    if: ${{ needs.depscheck.result }} == 'failure'
+    needs: gencheck
+    if: ${{ failure() }}
     uses: ./.github/workflows/comment-failure.yaml

.github/workflows/gradually-deprecated.yaml

@@ -24,8 +24,10 @@ jobs:
           go-version-file: ./.go-version
       - run: bash ./scripts/run-gradually-deprecated.sh
   save-artifacts-on-fail:
-    if: ${{ needs.test.result }} == 'failure'
+    needs: test
+    if: ${{ failure() }}
     uses: ./.github/workflows/save-artifacts.yaml
   comment-on-fail:
-    if: ${{ needs.depscheck.result }} == 'failure'
+    needs: test
+    if: ${{ failure() }}
     uses: ./.github/workflows/comment-failure.yaml

.github/workflows/link-milestone.yaml

@@ -18,7 +18,7 @@ jobs:
       - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
         with:
           # we cannot use go-version-file here because no repositories are checked out so there is no file to reference
-          go-version: '1.24.1'
+          go-version: '1.25.3'
       - run: |
           go install github.com/stephybun/link-milestone@latest
           link-milestone

.github/workflows/preview-api-version-linter.yaml

@@ -0,0 +1,27 @@
+---
+name: Preview ARM API Version Linter
+
+permissions:
+  contents: read
+  pull-requests: read
+
+on:
+  pull_request:
+    types: ["opened", "synchronize"]
+    paths:
+      - ".github/workflows/preview-api-version-linter.yaml"
+      - "internal/tools/preview-api-version-linter/**"
+      - "vendor/**"
+
+jobs:
+  preview-api-version-linter:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+      - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
+        with:
+          go-version-file: ./.go-version
+      - run: go run internal/tools/preview-api-version-linter/main.go
+  comment-on-fail:
+    if: ${{ needs.depscheck.result }} == 'failure'
+    uses: ./.github/workflows/comment-failure.yaml

.github/workflows/provider-release.yml

@@ -34,10 +34,10 @@ on:
         default: "staging"
 
 env:
-  slack_channel: "C7T8GB62H" # #tech-azure
+  slack_channel: "C09KX8BCGA2" # #tech-azure
   product_name: "terraform-provider-azurerm"
   repo_name: "terraform-provider-azurerm"
-  deployment_environment_name: "terraform-azure-repos-oss"
+  deployment_environment_name: "tf-provider-azurerm-oss"
 
 jobs:
   release:

.github/workflows/provider-test.yaml

@@ -81,8 +81,10 @@ jobs:
         run: rm -f "${RUNNER_TEMP}/client-secret"
         if: always()
   save-artifacts-on-fail:
-    if: ${{ needs.secrets-check.result }} == 'failure' || ${{ needs.provider-tests.result }} == 'failure'
+    needs: provider-tests
+    if: ${{ failure() }}
     uses: ./.github/workflows/save-artifacts.yaml
   comment-on-fail:
-    if: ${{ needs.depscheck.result }} == 'failure'
+    needs: provider-tests
+    if: ${{ failure() }}
     uses: ./.github/workflows/comment-failure.yaml

.github/workflows/teamcity-test.yaml

@@ -22,7 +22,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
-      - uses: actions/setup-java@c5195efecf7bdfc987ee8bae7a71cb8b11521c00 # v4.7.1
+      - uses: actions/setup-java@c1e323688fd81a25caa38c78aa6df2d33d3e20d9 # v4.8.0
         with:
           distribution: zulu
           java-version: 17

.github/workflows/tflint.yaml

@@ -28,8 +28,10 @@ jobs:
       - run: make tools
       - run: make tflint
   save-artifacts-on-fail:
-    if: ${{ needs.tflint.result }} == 'failure'
+    needs: tflint
+    if: ${{ failure() }}
     uses: ./.github/workflows/save-artifacts.yaml
   comment-on-fail:
-    if: ${{ needs.depscheck.result }} == 'failure'
+    needs: tflint
+    if: ${{ failure() }}
     uses: ./.github/workflows/comment-failure.yaml

.github/workflows/thirty-two-bit.yaml

@@ -28,8 +28,10 @@ jobs:
       - run: bash scripts/gogetcookie.sh
       - run: GOARCH=386 GOOS=linux go build -o 32bitbuild .
   save-artifacts-on-fail:
-    if: ${{ needs.compatibility-32bit-test.result }} == 'failure'
+    needs: compatibility-32bit-test
+    if: ${{ failure() }}
     uses: ./.github/workflows/save-artifacts.yaml
   comment-on-fail:
-    if: ${{ needs.depscheck.result }} == 'failure'
+    needs: compatibility-32bit-test
+    if: ${{ failure() }}
     uses: ./.github/workflows/comment-failure.yaml

.github/workflows/unit-test.yaml

@@ -30,8 +30,10 @@ jobs:
         env:
           GITHUB_ACTIONS_STAGE: "UNIT_TESTS"
   save-artifacts-on-fail:
-    if: ${{ needs.test.result }} == 'failure'
+    needs: test
+    if: ${{ failure() }}
     uses: ./.github/workflows/save-artifacts.yaml
   comment-on-fail:
-    if: ${{ needs.depscheck.result }} == 'failure'
+    needs: test
+    if: ${{ failure() }}
     uses: ./.github/workflows/comment-failure.yaml

.github/workflows/validate-examples.yaml

@@ -28,8 +28,10 @@ jobs:
       - run: make tools
       - run: make validate-examples
   save-artifacts-on-fail:
-    if: ${{ needs.website-lint.result }} == 'failure'
+    needs: website-lint
+    if: ${{ failure() }}
     uses: ./.github/workflows/save-artifacts.yaml
   comment-on-fail:
-    if: ${{ needs.depscheck.result }} == 'failure'
+    needs: website-lint
+    if: ${{ failure() }}
     uses: ./.github/workflows/comment-failure.yaml

.github/workflows/website-lint.yaml

@@ -26,8 +26,10 @@ jobs:
       - run: make website-lint
       - run: make document-validate
   save-artifacts-on-fail:
-    if: ${{ needs.website-lint.result }} == 'failure'
+    needs: website-lint
+    if: ${{ failure() }}
     uses: ./.github/workflows/save-artifacts.yaml
   comment-on-fail:
-    if: ${{ needs.depscheck.result }} == 'failure'
+    needs: website-lint
+    if: ${{ failure() }}
     uses: ./.github/workflows/comment-failure.yaml

.gitignore

@@ -57,6 +57,11 @@ tf.zip
 # do not upload .local folder
 .local
 
-# do not upload GitHub Copilot specific folders and copilot instructions file
+# do not upload GitHub Copilot specific folders and copilot instruction files
+.github/instructions
 .github/prompts
-.github/copilot-instructions.md
+.github/copilot-instructions.md
+
+# do not upload .bob instructions
+.bob
+AGENTS.md

.go-version

@@ -1 +1 @@
-1.24.5
+1.25.3

.release/ci.hcl

@@ -12,7 +12,7 @@ project "terraform-provider-azurerm" {
   team = "_UNUSED_"
 
   slack {
-    notification_channel = "C7T8GB62H" // #tech-azure
+    notification_channel = "C09KX8BCGA2" // #tech-azure
   }
 
   github {

.teamcity/components/generated/services.kt

@@ -1,4 +1,4 @@
-// Copyright (c) HashiCorp, Inc.
+// Copyright IBM Corp. 2014, 2025
 // SPDX-License-Identifier: MPL-2.0
 // NOTE: this is Generated from the Service Definitions - manual changes will be lost
 //       to re-generate this file, run 'make generate' in the root of the repository
@@ -77,13 +77,12 @@ var services = mapOf(
         "maintenance" to "Maintenance",
         "managedapplications" to "Managed Applications",
         "managedhsm" to "Managed HSM",
+        "managedredis" to "Managed Redis",
         "managedidentity" to "ManagedIdentity",
         "managementgroup" to "Management Group",
         "maps" to "Maps",
         "mssql" to "Microsoft SQL Server / Azure SQL",
         "mssqlmanagedinstance" to "Microsoft SQL Server Managed Instances",
-        "mixedreality" to "Mixed Reality",
-        "mobilenetwork" to "Mobile Network",
         "mongocluster" to "Mongo Cluster",
         "monitor" to "Monitor",
         "mysql" to "MySQL",

.teamcity/components/settings.kt

@@ -13,7 +13,7 @@ var defaultParallelism = 20
 var defaultTimeout = 12
 
 // specifies the default version of Terraform Core which should be used for testing
-var defaultTerraformCoreVersion = "1.12.2"
+var defaultTerraformCoreVersion = "1.14.3"
 
 // This represents a cron view of days of the week, Monday - Friday.
 const val defaultDaysOfWeek = "2,3,4,5,6"
@@ -60,6 +60,9 @@ var serviceTestConfigurationOverrides = mapOf(
         // Chaosstudio is only available in certain locations
         "chaosstudio" to testConfiguration(locationOverride = LocationConfiguration("westeurope", "eastus", "westus", false)),
 
+        // Codesigning is only available in certain locations
+        "codesigning" to testConfiguration(locationOverride = LocationConfiguration("westeurope", "eastus", "westus", true)),
+
         // "cognitive" is expensive - Monday, Wednesday, Friday
         // cognitive is only available in certain locations
         "cognitive" to testConfiguration(daysOfWeek = "2,4,6", locationOverride = LocationConfiguration("westeurope", "eastus", "southcentralus", true)),
@@ -119,12 +122,15 @@ var serviceTestConfigurationOverrides = mapOf(
         // Logic uses app service which is only available in certain locations
         "logic" to testConfiguration(locationOverride = LocationConfiguration("westeurope", "francecentral", "eastus2", false)),
 
+        // Rotate machinelearning acctest across supported-but-less-frequently-used locations to prevent quota and rate limiting
+        "machinelearning" to testConfiguration(locationOverride = LocationConfiguration("westus3", "northeurope", "uksouth", true)),
+
+        // Managed Redis is only available in certain locations, and has limited quota
+        "managedredis" to testConfiguration(locationOverride = LocationConfiguration("uksouth", "westus3", "southcentralus", true)),
+
         // Maps is only available in certain locations
         "maps" to testConfiguration(locationOverride = LocationConfiguration("westeurope", "westus2", "eastus", false)),
 
-        // MobileNetwork is only available in certain locations
-        "mobilenetwork" to testConfiguration(locationOverride = LocationConfiguration("eastus", "westeurope", "centraluseuap", false)),
-
         // Mongocluster free tier is currently only available in southindia
         "mongocluster" to testConfiguration(locationOverride = LocationConfiguration("westeurope", "eastus2", "southindia", false)),
 
@@ -159,7 +165,7 @@ var serviceTestConfigurationOverrides = mapOf(
 
         "policy" to testConfiguration(useAltSubscription = true),
 
-        "postgres" to testConfiguration(locationOverride = LocationConfiguration("northeurope", "centralus", "westeurope", false)),
+        "postgres" to testConfiguration(locationOverride = LocationConfiguration("westus3", "northeurope", "westeurope", false)),
 
         // Private DNS Resolver is only available in certain locations
         "privatednsresolver" to testConfiguration(locationOverride = LocationConfiguration("eastus", "westus3", "westeurope", true)),