wl_surface: don't propagate commit to ext if ext has changed since commit

[mahkoh]

Closes #1103

[Copilot]

Pull request overview

This PR introduces versioning for wl_surface extension objects so that commit/unmap callbacks are only forwarded to the extension that was active when the commit was recorded, addressing issue #1103 (avoiding compositor-side dismissal signals like popup_done() for client-destroyed popups).

Changes:

• Add ext_version tracking on WlSurface and propagate it through PendingState and queued Commit entries.
• Gate before_apply_commit, after_apply_commit, and timeline-driven unmap so they only run when pending.ext_version matches the current surface ext_version.
• Refactor multiple role installers (xdg/layer/input-popup/tray/session-lock) to attach extensions via a new WlSurface::set_ext(...) helper.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/ifs/wl_surface/zwp_input_popup_surface_v2.rs	Switch to centralized set_ext role+ext attachment.
src/ifs/wl_surface/zwlr_layer_surface_v1.rs	Switch to centralized set_ext role+ext attachment.
src/ifs/wl_surface/xdg_surface.rs	Switch to centralized set_ext role+ext attachment.
src/ifs/wl_surface/wl_subsurface.rs	Use set_ext_unchecked (now bumps ext_version) when attaching subsurface ext.
src/ifs/wl_surface/tray.rs	Switch to centralized set_ext role+ext attachment.
src/ifs/wl_surface/ext_session_lock_surface_v1.rs	Switch to centralized set_ext role+ext attachment.
src/ifs/wl_surface/commit_timeline.rs	Store ext_version per queued commit and use it for versioned unmap.
src/ifs/wl_surface.rs	Add ext_version, version-gated ext callbacks, and set_ext/set_ext_unchecked helpers plus HasExt error.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[witchlliee]

It does indeed fixes the issue. Thanks!