sync-obj: use DRM_SYNCOBJ_FD_TO_HANDLE_FLAGS_TIMELINE#766
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mahkoh
force-pushed
the
jorth/syncobj-direct-import
branch
from
66be521 to
660dc28
Compare
There was a problem hiding this comment.
Pull request overview
Updates the DRM syncobj import path to support importing sync files into timeline sync objects (when the kernel supports it), while keeping a fallback path for older kernels.
Changes:
- Add
DRM_SYNCOBJ_FD_TO_HANDLE_FLAGS_TIMELINEand plumb apointfield/argument through the syncobj FD import ioctl. - Detect and cache whether the running kernel supports timeline sync-file import, and use it when available.
- Refactor sync-file merging into a helper (
merge_sync_files) to simplifyimport_sync_files.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/video/drm/sys.rs |
Extends syncobj FD import bindings with TIMELINE flag support and a point field in the ioctl struct. |
src/video/drm/sync_obj.rs |
Uses the new TIMELINE import path when supported; adds capability detection and refactors sync-file merging. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.