Merged
Conversation
mahkoh
force-pushed
the
fix-shell-completions
branch
from
d6702b0 to
4c656f2
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes a copy-paste bug where three applications (wl-paper, wl-format-filter, and window-to-tray) were incorrectly generating shell completions with the name "wl-veil" instead of their own application names.
Changes:
- Updated wl-paper to generate completions for "wl-paper" instead of "wl-veil"
- Updated wl-format-filter to generate completions for "wl-format-filter" instead of "wl-veil"
- Updated window-to-tray to generate completions for "window-to-tray" instead of "wl-veil"
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/wl-paper/src/cli.rs | Corrected completion name from "wl-veil" to "wl-paper" |
| apps/wl-format-filter/src/cli.rs | Corrected completion name from "wl-veil" to "wl-format-filter" |
| apps/window-to-tray/src/cli.rs | Corrected completion name from "wl-veil" to "window-to-tray" and reformatted call |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Sorry for the delay, I accidentally disabled notifications for this repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All 3 apps other than wl-veil generate completions for wl-veil.