Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the river-window-management-v1 Wayland protocol and its corresponding Rust bindings by adding documentation summaries to previously undocumented function parameters. The changes are auto-generated and affect only documentation comments - no code logic is modified.
Changes:
- Added documentation summaries to protocol XML argument definitions in river-window-management-v1.xml
- Updated generated Rust documentation in protocol binding files to reflect the XML documentation changes
- Improved clarity of the description for pointer bindings (changed "modifiers" to "keyboard modifiers" for precision)
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| protocols/river-protocols/river-window-management-v1.xml | Added summary attributes to all previously undocumented protocol arguments, clarifying parameter purposes |
| wl-proxy/src/protocols/river_window_management_v1/river_window_v1.rs | Updated generated Rust doc comments for RiverWindowV1 methods to include parameter descriptions |
| wl-proxy/src/protocols/river_window_management_v1/river_window_manager_v1.rs | Updated generated Rust doc comments for RiverWindowManagerV1 methods to include parameter descriptions |
| wl-proxy/src/protocols/river_window_management_v1/river_shell_surface_v1.rs | Updated generated Rust doc comments for RiverShellSurfaceV1 methods to include parameter descriptions |
| wl-proxy/src/protocols/river_window_management_v1/river_seat_v1.rs | Updated generated Rust doc comments for RiverSeatV1 methods to include parameter descriptions |
| wl-proxy/src/protocols/river_window_management_v1/river_output_v1.rs | Updated generated Rust doc comments for RiverOutputV1 methods to include parameter descriptions |
| wl-proxy/src/protocols/river_window_management_v1/river_node_v1.rs | Updated generated Rust doc comments for RiverNodeV1 methods to include parameter descriptions |
| wl-proxy/src/protocols/river_window_management_v1/river_decoration_v1.rs | Updated generated Rust doc comments for RiverDecorationV1 methods to include parameter descriptions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-generated by create-pull-request