Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the generated Wayland core protocol bindings and baseline version metadata to a newer protocol snapshot, adding newly introduced requests and bumping interface versions accordingly.
Changes:
- Bump core Wayland interface versions (e.g.,
wl_surfaceto v7, data-device-related interfaces to v4) across generated Rust bindings and baseline version files. - Add support for
wl_surface.get_release(since v7) and the newwl_surface.error.no_bufferenum value. - Add
releasedestructors forwl_compositor(since v7) andwl_data_device_manager(since v4), including request forwarding/dispatch support.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
wl-proxy/src/protocols/wayland/wl_surface.rs |
Bumps wl_surface to v7 and adds get_release request support plus no_buffer error constant. |
wl-proxy/src/protocols/wayland/wl_region.rs |
Updates generated wl_region interface version constant. |
wl-proxy/src/protocols/wayland/wl_data_source.rs |
Updates generated wl_data_source interface version constant. |
wl-proxy/src/protocols/wayland/wl_data_offer.rs |
Updates generated wl_data_offer interface version constant. |
wl-proxy/src/protocols/wayland/wl_data_device_manager.rs |
Bumps to v4 and adds release destructor request + dispatch/forwarding. |
wl-proxy/src/protocols/wayland/wl_data_device.rs |
Updates generated wl_data_device interface version constant. |
wl-proxy/src/protocols/wayland/wl_compositor.rs |
Bumps to v7 and adds release destructor request + dispatch/forwarding. |
wl-proxy/src/protocols.rs |
Updates ObjectInterface → max-version mapping for updated core interfaces. |
wl-proxy/src/baseline/versions/prototyping.txt |
Updates baseline protocol version list to match regenerated protocol snapshot. |
wl-proxy/src/baseline/versions/prototyping.rs |
Updates baseline protocol version constants to match regenerated protocol snapshot. |
protocols/wayland/wayland.xml |
Updates Wayland core XML: version bumps plus wl_surface.get_release request and no_buffer error entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-generated by create-pull-request