Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a suspend/unsuspend mechanism to pause dispatching messages per endpoint (client-side and server-side) and updates the test framework + tests to exercise and validate the new behavior.
Changes:
- Add per-endpoint suspension state and public APIs (
Client::set_suspended,State::set_suspended) to pause message dispatching. - Add an
eventfd-based wake mechanism wired into the poll loop (plus an edge-triggered epoll registration helper). - Refactor
TestProxyto group client-related handles undertp.client.*and update all affected tests; add new suspend-focused tests.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| wl-proxy/src/state.rs | Implements suspension queueing/wakeup and integrates it into dispatch flow. |
| wl-proxy/src/state/builder.rs | Adds static pollable IDs and initializes/registers the unsuspend eventfd. |
| wl-proxy/src/endpoint.rs | Adds suspension flags and stops message dispatch when suspended. |
| wl-proxy/src/client.rs | Exposes Client::set_suspended API for client endpoint suspension. |
| wl-proxy/src/poll.rs | Adds edge-triggered registration helper (register_edge_triggered). |
| wl-proxy/src/poll/tests.rs | Adds test coverage for edge-triggered registration behavior. |
| wl-proxy/src/test_framework/proxy.rs | Refactors test proxy API (nested TestProxyClient) and adds create_client. |
| wl-proxy/src/state/tests.rs | Updates existing tests for new proxy API and adds suspend behavior tests. |
| wl-proxy/src/*/tests.rs (trans/object/endpoint/global_mapper/client) | Mechanical updates to use tp.client.* fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mahkoh
force-pushed
the
jorth/suspend
branch
from
bcf4de3 to
dd6d97d
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.