Restrict netfilter container to required capabilities instead of running as privileged container#7048
Open
mstilkerich wants to merge 1 commit intomailcow:stagingfrom
Open
Conversation
It only required NET_ADMIN capability in order to manipulate the iptables/nftables rules.
|
Great to address this issue, I also stumbled against it... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
What does this PR include?
Short Description
This PR changes the configuration of the netfilter container to only run with the
NET_ADMINcapability instead of a privileged container (all capabilities). The only privileged operation performed by the container is manipulation of the iptables/nftables rulesets, which is possible having theNET_ADMINcapability (and using the host network stack, which is already the case).Affected Containers
Did you run tests?
What did you test?
I ran the container and manually created and removed a ban by adding an IP address in the admin interface and later removing it again. After adding / removing I checked in the container logs until the change arrived at the container, then checked that the nftables ruleset was updated accordingly (rule was added/removed).
What were the final results? (Awaited, got)
The rule was added and later removed as expected. No error show in the netfilter logs.