Correct typo in attribute 'ignore_ssl_error'#7052
Open
admins-little-helper wants to merge 8 commits intomailcow:stagingfrom
Open
Correct typo in attribute 'ignore_ssl_error'#7052admins-little-helper wants to merge 8 commits intomailcow:stagingfrom
admins-little-helper wants to merge 8 commits intomailcow:stagingfrom
Conversation
* Initial plan * Fix duplicate login announcement display Co-authored-by: DerLinkman <62480600+DerLinkman@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: DerLinkman <62480600+DerLinkman@users.noreply.github.com>
…rify-hash Support for PBKDF2-SHA512 hash algorithm in verify_hash() (FreeIPA compatibility) (issue 6646)
🐄🛡️ January 2026 Update | Limited EAS/DAV Access and Restricted Alias Sending
[Hotfix] Update 2026-01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
What does this PR include?
Short Description
The API endpoint '/get/identity-provider' returns an invalid attribute 'ignore_ssl_errors' (plural) in addition to the valid attribute 'ignore_ssl_error' (singular).
This seems to be a typo in /data/web/inc/functions.inc.php. The 'edit/identity-provider' API endpoint expects 'ignore_ssl_error'.
The consequence of this typo is that:
Affected Containers
N/A
Did you run tests?
What did you tested?
The result contains attribute 'ignore_ssl_error' set to an empty string (line 11) and 'ignore_ssl_errors' in line 25.
{ "access_token": "", "attribute_field": "extensionattribute15", "authsource": "ldap", "basedn": "DC=domain,DC=local", "binddn": "CN=svc-ldap,OU=ServiceAccounts,DC=domain,DC=local", "bindpass": "securepassword", "default_template": "Default", "filter": "(&(objectClass=user)(mail=*example.com))", "host": "False", "ignore_ssl_error": "", "import_users": "1", "login_provisioning": true, "mappers": [ "mailcow" ], "periodic_sync": "1", "port": "389", "sync_interval": "2", "templates": [ "example.com" ], "username_field": "mail", "use_ssl": false, "use_tls": false, "ignore_ssl_errors": false }What were the final results? (Awaited, got)
After applying the fix, an API call to 'get/identity-provider' returns the following correct results.
The attribute value of 'ignore_ssl_error' correctly shows 'false' instead of an empty string (line 11).
The invalid attribute name 'ignore_ssl_errors' is no longer returned.
{ "access_token": "", "attribute_field": "extensionattribute15", "authsource": "ldap", "basedn": "DC=domain,DC=local", "binddn": "CN=svc-ldap,OU=ServiceAccounts,DC=domain,DC=local", "bindpass": "securepassword", "default_template": "Default", "filter": "(&(objectClass=user)(mail=*example.com))", "host": "False", "ignore_ssl_error": false, "import_users": "1", "login_provisioning": true, "mappers": [ "mailcow" ], "periodic_sync": "1", "port": "389", "sync_interval": "2", "templates": [ "example.com" ], "username_field": "mail", "use_ssl": false, "use_tls": false }