Fix theme localStorage collision with rspamd UI#7121
Open
rezzorix wants to merge 1 commit intomailcow:stagingfrom
Open
Fix theme localStorage collision with rspamd UI#7121rezzorix wants to merge 1 commit intomailcow:stagingfrom
rezzorix wants to merge 1 commit intomailcow:stagingfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
What does this PR include?
Fixes #7083
Fix theme preference collision between mailcow admin UI (/admin) and rspamd UI (/rspamd).
Both used the same localStorage key "theme".
Because both run on the same origin, changing the theme in one UI overwrote the other.
This PR introduces a separate key "mailcow_theme" for the mailcow UI and removes localStorage.clear().
Short Description
Fix theme collision between mailcow UI and rspamd UI.
Affected Containers
Did you run tests?
What did you tested?
Manual testing only.
What were the final results? (Awaited, got)
Awaited: mailcow ui / rspamd ui keep independent themes.
Got: Themes no longer overwrite each other.