Pin tld package to maintain py2 support

[bradchiappetta]

In order to maintain py2 support tld needs to be pinned : tld==0.10
https://github.com/barseghyanartur/tld/releases

[mailgun-ci]

Can one of the admins verify this patch?

[punkrokk]

@horkhe this PR pins tld==0.10 (the last version that supports py2) can you merge or let me know what else is needed to merge?

[horkhe]

I do not think it makes sense to pin tld in the library, for python3 users may not be happy about it. If the library is used by a Python2 application it is application's responsibility to install relevant tld version. That is what we do.

[punkrokk]

Ok. So are you saying you no longer support python2? I could make an alternate approach where it pins it for Py2 installs, but not py3. I understand your point but it’s gonna cause problems for py2 users. Your read me at the moment even says use py3 at your own risk Cheers, JP

…

On Dec 11, 2019, at 1:14 AM, Maxim Vladimirskiy ***@***.***> wrote:  I do not think it makes sense to pin tld in the library, for python3 users may not be happy about it. If the library is used by a Python2 application it is applications responsibility to install relevant tld version. That is what we do. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

[horkhe]

I am not saying that we do not support python 2. I am saying it is your application responsibility to pin versions. Each our python application has requirements.txt file where all dependency versions are pinned. I recommend you to do the same. Pinning version here will immediately cause issues if another your dependency pins to another tld version.