Account for a cached value of False when validating.#31
Open
dmpayton wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I had an issue on django-flanker that I've traced to flanker itself.
dmpayton/django-flanker#2
If
connect_to_mail_exchangerthrows an exception or fails to connect for whatever, it returns None andmail_exchanger_lookupwill setmx_cache[domain]to False.This is not accounted for on subsequent calls to
validate_address. If the cached value is None, it returns None, otherwise it continues. If the cached value is False, it throws the following exception:This patch simply returns None if the cached value is False.