DE-1538 Add endpoint for Running Inbox Placement Test#487
Merged
Conversation
vtopc
marked this pull request as ready for review
July 18, 2026 18:07
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support in the Go client for running InboxReady “Inbox Placement” tests (POST /v4/inbox/tests), aligning client types/mocks/tests with the generated InboxReady OpenAPI models.
Changes:
- Added
CreateInboxPlacementTestto the client andMailguninterface, plus a basic unit test. - Introduced new
mtypesaliases/constants for the Inbox Placement endpoint and request/response models. - Updated OpenAPI codegen tooling in the Makefile and regenerated
internal/types/inboxreadymodels with oapi-codegen v2.8.0.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
mtypes/inbox_placement.go |
Adds Inbox Placement constants and exported request/response type aliases. |
mocks/mock.go |
Registers Inbox Placement routes in the mock server. |
mocks/mock_inbox_placement.go |
Implements mock POST /v4/inbox/tests handler/response. |
Makefile |
Adds pinned oapi-codegen v2.8.0 install target and uses it for model generation. |
mailgun.go |
Adds CreateInboxPlacementTest to the Mailgun interface (and reorders API key methods). |
internal/types/inboxready/model.gen.go |
Regenerated OpenAPI models using oapi-codegen v2.8.0. |
inbox_placement.go |
Implements (*Client).CreateInboxPlacementTest. |
inbox_placement_test.go |
Adds a test covering the new endpoint integration with mocks. |
Files not reviewed (1)
- internal/types/inboxready/model.gen.go: Generated file
| $(GOLANGCI_LINT) run | ||
|
|
||
| ## Download OpenAPI 3.1 spec files and generate models | ||
| ## Downloads OpenAPI 3.1 spec files and generate models |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://documentation.mailgun.com/docs/inboxready/api-reference/optimize/inboxready/inbox-placement/post-v4-inbox-tests#/docs/inboxready/api-reference/optimize/inboxready/inbox-placement/get-v4-inbox-sharing-public--shareid-