Skip to content

DE-1538 Add endpoint for Running Inbox Placement Test#487

Merged
vtopc merged 5 commits into
mainfrom
vtopc/DE-1538_run_inbox_placement_test
Jul 18, 2026
Merged

DE-1538 Add endpoint for Running Inbox Placement Test#487
vtopc merged 5 commits into
mainfrom
vtopc/DE-1538_run_inbox_placement_test

Conversation

@vtopc
vtopc marked this pull request as ready for review July 18, 2026 18:07
Copilot AI review requested due to automatic review settings July 18, 2026 18:07
@vtopc
vtopc merged commit d7f2dd4 into main Jul 18, 2026
4 checks passed
@vtopc
vtopc deleted the vtopc/DE-1538_run_inbox_placement_test branch July 18, 2026 18:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support in the Go client for running InboxReady “Inbox Placement” tests (POST /v4/inbox/tests), aligning client types/mocks/tests with the generated InboxReady OpenAPI models.

Changes:

  • Added CreateInboxPlacementTest to the client and Mailgun interface, plus a basic unit test.
  • Introduced new mtypes aliases/constants for the Inbox Placement endpoint and request/response models.
  • Updated OpenAPI codegen tooling in the Makefile and regenerated internal/types/inboxready models with oapi-codegen v2.8.0.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
mtypes/inbox_placement.go Adds Inbox Placement constants and exported request/response type aliases.
mocks/mock.go Registers Inbox Placement routes in the mock server.
mocks/mock_inbox_placement.go Implements mock POST /v4/inbox/tests handler/response.
Makefile Adds pinned oapi-codegen v2.8.0 install target and uses it for model generation.
mailgun.go Adds CreateInboxPlacementTest to the Mailgun interface (and reorders API key methods).
internal/types/inboxready/model.gen.go Regenerated OpenAPI models using oapi-codegen v2.8.0.
inbox_placement.go Implements (*Client).CreateInboxPlacementTest.
inbox_placement_test.go Adds a test covering the new endpoint integration with mocks.
Files not reviewed (1)
  • internal/types/inboxready/model.gen.go: Generated file

Comment thread inbox_placement.go
Comment thread Makefile
$(GOLANGCI_LINT) run

## Download OpenAPI 3.1 spec files and generate models
## Downloads OpenAPI 3.1 spec files and generate models

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next time

Comment thread mtypes/inbox_placement.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants