Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/mailgun/webhooks/webhooks.rb
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ def create(domain, action, url = '')
# Returns true or false
# :nocov:
%i[create_all add_all_webhooks].each do |method|
define_method(method) do |domain|
define_method(method) do |domain, url|
url ||= ''
warn("`#{method}` method will be deprecated in future versions of Mailgun. Please use `create` instead.")

ACTIONS.each do |action|
Expand Down
23 changes: 23 additions & 0 deletions spec/unit/webhooks_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# frozen_string_literal: true

require 'spec_helper'

describe Mailgun::Webhooks do
let(:client) { double(:client) }
let(:webhooks) { described_class.new(client) }
let(:domain) { 'example.com' }
let(:url) { 'https://example.com/mailgun/events' }

%i[create_all add_all_webhooks].each do |method|
describe "##{method}" do
it 'creates every webhook action with the provided URL' do
described_class::ACTIONS.each do |action|
expect(webhooks).to receive(:create).with(domain, action, url).ordered
end

expect { webhooks.public_send(method, domain, url) }
.to output(/`#{method}` method will be deprecated/).to_stderr
end
end
end
end
Loading