Skip to content
This repository was archived by the owner on Aug 26, 2025. It is now read-only.

Update fork and support business latency requirements#2

Merged
ashleyelder merged 122 commits into
mainfrom
update-upstream-sync
Aug 18, 2025
Merged

Update fork and support business latency requirements#2
ashleyelder merged 122 commits into
mainfrom
update-upstream-sync

Conversation

@ashleyelder
Copy link
Copy Markdown

@ashleyelder ashleyelder commented Aug 1, 2025

  • catches up on 6 years worth of updates from upstream: https://github.com/likexian/whois#
  • adds backwards compatible update to support more strict timeouts on operations: 6b73da0
    • (our org requires 1 second timeout for reading and writing, which may be the reason this fork was created in the first place
    • I found the 1 second timeout change was the only difference we had from upstream 6 years ago: https://github.com/mailgun/whois-go/pull/1/files)
  • fixes build/linting errors
    • upstream actually has a red build that hasn't be resolved in 6 mos. IMO it may one day be worth evaluating maintaining our own whois-go rather than depend on an unreliable system

usage that will be applied to domain-analysis:

client := NewClient()
client.SetAbsoluteTimeout(true)  
client.SetTimeout(1 * time.Second)

@ashleyelder ashleyelder changed the title Update upstream sync Update fork and support business latency requirements Aug 1, 2025
@ashleyelder ashleyelder marked this pull request as ready for review August 1, 2025 17:55
@ashleyelder
Copy link
Copy Markdown
Author

sorry, this probably should have been a single initial PR just to update this fork. that said, the functional change i made to make it match business requirements was only one small commit change

Comment thread .github/workflows/release.yaml Outdated
Comment thread README.md Outdated
Comment thread .github/workflows/gotest.yaml Outdated
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... for module github.com/mailgun/whois-go

Comment thread README.md Outdated
All of domain, IP include IPv4 and IPv6, ASN are supported.

Or you can do development by using the golang module as below.
You can directly using the binary distributions whois, follow [whois release tool](cmd/whois).
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit-grammar: "you can directly using"

Comment thread README.md Outdated

go get -u github.com/likexian/whois-go
```shell
go get -u github.com/mailgun/whois-go
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: we've been avoiding -u for a variety of reasons.

@ashleyelder ashleyelder merged commit 3ae2350 into main Aug 18, 2025
10 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.