Fix handling of anon structs with embedded structs and fields #339
+72
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the anon struct embeds another struct _and_ contains fields of its own, there were cases where the generated code would ignore the anon struct's own fields. This happened because when checking if the anon struct implements a marshaling interface, the reflect package returns true if the anon struct's _embedded struct_ implements that interface. But using that interface means that the other fields in the anon struct are ignored.
autarch
force-pushed
the
autarch/embedded-field-and-sibling-fix
branch
from
b7d8b50 to
6ea728d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.