Skip to content

fix: allow feat commits to bump minor version in pre-1.0.0 releases#49

Merged
jcouball merged 1 commit into
mainfrom
fix-release-please-version-bump
Dec 18, 2025
Merged

fix: allow feat commits to bump minor version in pre-1.0.0 releases#49
jcouball merged 1 commit into
mainfrom
fix-release-please-version-bump

Conversation

@jcouball

Copy link
Copy Markdown
Member

Problem

Release-please was configured with bump-patch-for-minor-pre-major: true, which caused feat: commits to only bump the patch version (0.1.1 → 0.1.2) instead of the minor version (0.1.1 → 0.2.0) for pre-1.0.0 releases.

This made it impossible to distinguish between feature releases and patch releases in version numbers.

Solution

Remove the bump-patch-for-minor-pre-major setting from .release-please-config.json.

Impact

After this change, version bumping will work as follows for versions < 1.0.0:

Commit Type Version Bump Example
feat: minor 0.1.1 → 0.2.0
BREAKING CHANGE: minor 0.1.1 → 0.2.0
fix: patch 0.1.1 → 0.1.2

For versions ≥ 1.0.0, standard semantic versioning applies (BREAKING CHANGE bumps major).

Next Steps

Once this PR is merged, the next release-please run should correctly suggest version 0.2.0 instead of 0.1.2 for the pending release that includes multiple feature commits.

Copilot AI review requested due to automatic review settings December 18, 2025 17:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the release-please configuration to enable proper semantic versioning for pre-1.0.0 releases by removing the bump-patch-for-minor-pre-major setting. This allows feat: commits to bump the minor version (e.g., 0.1.1 → 0.2.0) instead of only the patch version (0.1.1 → 0.1.2), making it possible to distinguish between feature releases and patch releases in version numbers.

Key Changes

  • Removes the conflicting bump-patch-for-minor-pre-major: true setting that was preventing proper semantic versioning
  • Retains bump-minor-pre-major: true to ensure breaking changes bump the minor version for pre-1.0.0 releases

Comment thread .release-please-config.json
@jcouball
jcouball force-pushed the fix-release-please-version-bump branch 2 times, most recently from d2a830a to c9ca72c Compare December 18, 2025 17:56
Remove bump-patch-for-minor-pre-major setting to restore standard
semantic versioning behavior for pre-1.0.0 versions.

With this change:
- feat: commits bump minor version (0.1.1 → 0.2.0)
- BREAKING CHANGE: commits bump minor version (0.1.1 → 0.2.0)
- fix: commits bump patch version (0.1.1 → 0.1.2)

Previously, bump-patch-for-minor-pre-major caused feat: commits
to only bump patch versions, which prevented proper version
signaling for new features in pre-1.0.0 releases.
@jcouball
jcouball force-pushed the fix-release-please-version-bump branch from c9ca72c to 3581f05 Compare December 18, 2025 17:59
@jcouball
jcouball merged commit 6c43c4b into main Dec 18, 2025
8 checks passed
@jcouball
jcouball deleted the fix-release-please-version-bump branch December 18, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants