Remove @embroider/macros from dependencies#3105
Conversation
|
In that case it needs to be a peerDependency at the very least, since liquid-fire#package.json |
nay, it's not a runtime dependency
there is nothing to be present -- macros is actually just signalling to the consumers' babel
they are all wrong 🙈 lol
yup!
nope -- bugfix -- in the worst case, users won't notice -- in the best case, it unblocks people from using vite (blockers include: duplicate macros state (isTesting, etc)) |
@embroider/macros from dependencies
macros is an external as it is a build time behavior controlled by the consumer
also we don't want macros to show up in optimized deps