Skip to content

Remove @embroider/macros from dependencies#3105

Merged
BobrImperator merged 2 commits into
mainmatter:masterfrom
NullVoxPopuli:nvp/remove-macros
Jun 13, 2026
Merged

Remove @embroider/macros from dependencies#3105
BobrImperator merged 2 commits into
mainmatter:masterfrom
NullVoxPopuli:nvp/remove-macros

Conversation

@NullVoxPopuli

Copy link
Copy Markdown
Contributor

macros is an external as it is a build time behavior controlled by the consumer

also we don't want macros to show up in optimized deps

@BobrImperator

BobrImperator commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

In that case it needs to be a peerDependency at the very least, since @embroider/macros must be present at build time for consumers. While it's also not generally installed in apps themselves unless the apps have their own need for it.
I'm not opposed here but AFAIK most addons I've seen declare it a dependency, which could've been a multi-year mistake 😅.
Overall this likely is a breaking change?

liquid-fire#package.json
ember-qunit@9.04#package.json -> ember-qunit@9.1.0 already changed it.

@NullVoxPopuli

NullVoxPopuli commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

In that case it needs to be a peerDependency at the very least,

nay, it's not a runtime dependency

since @embroider/macros must be present at build time for consumers.

there is nothing to be present -- macros is actually just signalling to the consumers' babel

I'm not opposed here but AFAIK most addons I've seen declare it a dependency,

they are all wrong 🙈 lol

which could've been a multi-year mistake

yup!

Overall this likely is a breaking change?

nope -- bugfix -- in the worst case, users won't notice -- in the best case, it unblocks people from using vite (blockers include: duplicate macros state (isTesting, etc))

@BobrImperator BobrImperator added the dependencies Pull requests that update a dependency file label Jun 13, 2026
@BobrImperator BobrImperator changed the title Remove macros Remove @embroider/macros from dependencies Jun 13, 2026
@BobrImperator BobrImperator merged commit 7698aa4 into mainmatter:master Jun 13, 2026
30 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants